fix: correct style and stack counts in plugin.json description#282
Open
xiaolai wants to merge 1 commit into
Open
fix: correct style and stack counts in plugin.json description#282xiaolai wants to merge 1 commit into
xiaolai wants to merge 1 commit into
Conversation
This was referenced Apr 26, 2026
The marketplace description claimed "67 styles, 15 stacks" but: - styles.csv contains 84 style entries (actual count) - The description itself lists exactly 12 stacks, not 15 Update to "84 styles, 12 stacks" to match the actual data. Co-Authored-By: Claude Code <noreply@anthropic.com>
xiaolai
force-pushed
the
fix/nlpm-plugin-json-count-mismatch
branch
from
d967fb6 to
8572ba7
Compare
xiaolai
changed the title
mrgoonie
requested changes
Jun 21, 2026
mrgoonie
left a comment
mrgoonie
left a comment
Contributor
There was a problem hiding this comment.
Summary: This PR correctly identifies that the plugin manifest count text is stale, but the proposed fix would make the manifest inconsistent with the repo's current source-of-truth stack data and with the adjacent marketplace metadata.
Risk level: Low
Mandatory gates:
- Duplicate/prior implementation: partial overlap found with metadata cleanup PR #327, but no merged PR fixes these count values.
- Project standards: issue found — repo guidance treats source data/templates/metadata consistency as important, and this only changes one manifest string.
- Strategic necessity: clear value — accurate marketplace/plugin metadata matters for user expectations.
- CI/checks: missing/not required for this one-line metadata change.
Findings:
- Important: The PR changes
.claude-plugin/plugin.jsonfrom15 stacksto12 stacks, but the current source data has 16 stack CSVs undersrc/ui-ux-pro-max/data/stacks/(angular,astro,flutter,html-tailwind,jetpack-compose,laravel,nextjs,nuxt-ui,nuxtjs,react,react-native,shadcn,svelte,swiftui,threejs,vue). The description should not downgrade the stack count to the shorter enumerated list; it should align with the source data or update the listed stack names to match. - Important:
.claude-plugin/marketplace.jsonstill says67 styles ... 15 stack guidelines, so accepting this PR as-is leaves marketplace/plugin metadata inconsistent. Please update the related marketplace/plugin metadata together, or explain why onlyplugin.jsonshould differ.
Verdict: REQUEST_CHANGES
mrgoonie
added
agent:github-maintain
pull Bot
pushed a commit
to LeeeeeeM/ui-ux-pro-max-skill
that referenced
this pull request
Jun 25, 2026
…lder#289) (nextlevelbuilder#391) The marketplace-facing manifests understated the catalog. Actual data: 84 styles (styles.csv), 73 font pairings (typography.csv), and 17 stacks (data/stacks/*.csv), but plugin.json, marketplace.json, and skill.json all claimed 67 styles / 57 font pairings / 15 stacks. Update the three manifests to 84 / 73 / 17, and extend the stack enumeration to the full 17 (adding Angular, Laravel, JavaFX, Three.js, and Nuxt UI). Palettes (161) and charts (25) were already correct. Resolves the count-drift finding in nextlevelbuilder#289 (supersedes the stuck nextlevelbuilder#282 and nextlevelbuilder#329, which only partially corrected the numbers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The marketplace description in `.claude-plugin/plugin.json` contains two count mismatches:
Why it matters: The plugin description is what users see on the Claude marketplace. Overstating the database size sets incorrect expectations — users expect 67 styles and 15 stacks but the documented and installed database is different.
Fix: Update the description to `84 styles, 12 stacks` to match the authoritative data. The stacks listed in the description itself count to 12, so no stack list changes are required.