fix(SKILL.md): add explicit "Use when..." trigger phrase#310
Open
Lucianobuju wants to merge 1 commit into
Open
fix(SKILL.md): add explicit "Use when..." trigger phrase#310Lucianobuju wants to merge 1 commit into
Lucianobuju wants to merge 1 commit into
Conversation
Author
|
Resolves the audit warning reported in #[ISSUE_ID_DE_HIER] Adds the literal "Use when…" trigger phrase to both:
Cost: ~30 chars of the 1024-char budget per spec. Tested locally: skill installs cleanly, audit script now reports ✓. |
mrgoonie
requested changes
Jun 21, 2026
mrgoonie
left a comment
Contributor
There was a problem hiding this comment.
Summary: This PR tries to add an explicit trigger phrase to the Claude install metadata, but the current edit is not merge-ready because it replaces the full capability description with placeholder text and edits only the generated CLI asset copy.
Risk level: Medium
Mandatory gates:
- Duplicate/prior implementation: overlap found with #311, which attempts the same trigger-phrase direction in the derived Claude skill copy and has already been reviewed with the same placeholder/source-of-truth concern.
- Project standards: issue found — current main keeps the canonical Claude platform metadata in src/ui-ux-pro-max/templates/platforms/claude.json, while cli/assets/templates/platforms/claude.json is a packaged/generated mirror. These paths are already out of sync on stack counts, and this PR changes only the mirror.
- Strategic necessity: clear value — an explicit "Use when..." phrase can help skill discovery if added cleanly.
- CI/checks: missing/not reported; diff is metadata-only, but the source/mirror gate fails.
Findings:
- Important: The new description ends with
[reste de la description existante], which is placeholder/editorial text rather than valid published skill metadata. It also drops the existing actions/projects/topics/integration details and stale-count context instead of preserving or updating them. - Important: The PR edits only
cli/assets/templates/platforms/claude.json. The canonicalsrc/ui-ux-pro-max/templates/platforms/claude.jsonstill has the original description and current 16-stack wording, so this one-off packaged-asset edit would be overwritten or leave generated installs inconsistent. Please apply the trigger phrase to the canonical source, preserve the full real description, and sync the CLI asset copy.
Verdict: REQUEST_CHANGES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.