Skip to content

fix(SKILL.md): add explicit "Use when..." trigger phrase#310

Open
Lucianobuju wants to merge 1 commit into
nextlevelbuilder:mainfrom
Lucianobuju:patch-1
Open

fix(SKILL.md): add explicit "Use when..." trigger phrase#310
Lucianobuju wants to merge 1 commit into
nextlevelbuilder:mainfrom
Lucianobuju:patch-1

Conversation

@Lucianobuju

Copy link
Copy Markdown

No description provided.

@Lucianobuju

Copy link
Copy Markdown
Author

Resolves the audit warning reported in #[ISSUE_ID_DE_HIER]

Adds the literal "Use when…" trigger phrase to both:

  • .claude/skills/ui-ux-pro-max/SKILL.md (source SKILL definition)
  • cli/assets/templates/platforms/claude.json (CLI-rendered Claude install)

Cost: ~30 chars of the 1024-char budget per spec.
Benefit: passes agentskills.io/specification.md audit + makes trigger semantics explicit.

Tested locally: skill installs cleanly, audit script now reports ✓.

@mrgoonie mrgoonie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This PR tries to add an explicit trigger phrase to the Claude install metadata, but the current edit is not merge-ready because it replaces the full capability description with placeholder text and edits only the generated CLI asset copy.

Risk level: Medium

Mandatory gates:

  • Duplicate/prior implementation: overlap found with #311, which attempts the same trigger-phrase direction in the derived Claude skill copy and has already been reviewed with the same placeholder/source-of-truth concern.
  • Project standards: issue found — current main keeps the canonical Claude platform metadata in src/ui-ux-pro-max/templates/platforms/claude.json, while cli/assets/templates/platforms/claude.json is a packaged/generated mirror. These paths are already out of sync on stack counts, and this PR changes only the mirror.
  • Strategic necessity: clear value — an explicit "Use when..." phrase can help skill discovery if added cleanly.
  • CI/checks: missing/not reported; diff is metadata-only, but the source/mirror gate fails.

Findings:

  • Important: The new description ends with [reste de la description existante], which is placeholder/editorial text rather than valid published skill metadata. It also drops the existing actions/projects/topics/integration details and stale-count context instead of preserving or updating them.
  • Important: The PR edits only cli/assets/templates/platforms/claude.json. The canonical src/ui-ux-pro-max/templates/platforms/claude.json still has the original description and current 16-stack wording, so this one-off packaged-asset edit would be overwritten or leave generated installs inconsistent. Please apply the trigger phrase to the canonical source, preserve the full real description, and sync the CLI asset copy.

Verdict: REQUEST_CHANGES

@mrgoonie mrgoonie added agent:github-maintain Processed by github-maintain automation pr:reviewed PR reviewed by maintain workflow pr:changes-requested Maintain review requested changes labels Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:github-maintain Processed by github-maintain automation pr:changes-requested Maintain review requested changes pr:reviewed PR reviewed by maintain workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants