fix: ship skill assets as real copies for Windows compatibility

[BeyBaba]

Summary

The skill at .claude/skills/ui-ux-pro-max/ ships data and scripts as filesystem symlinks pointing at ../../../src/ui-ux-pro-max/{data,scripts}. On Windows clones — and any environment where git config core.symlinks defaults to false — git materialises those entries as plain text files containing the symlink target string. The skill then breaks at runtime:

PS> cd .claude/skills/ui-ux-pro-max
PS> python scripts/search.py "fintech crypto" --design-system
# error: scripts/search.py not found / not a directory

This affects users installing the plugin via claude plugin install ui-ux-pro-max@ui-ux-pro-max-skill on Windows.

Fix

• Replace the two symlinks with real file copies of data/ (1.7 MB, 31 CSVs) and scripts/ (3 Python modules).
• Add scripts/sync-skill-assets.sh and scripts/sync-skill-assets.ps1 so maintainers can refresh the skill folder after editing the source of truth — mirroring the existing cp -r src/... cli/assets/... workflow already documented for the CLI assets in CLAUDE.md.
• Update CLAUDE.md Sync Rules to document the new workflow and the Windows rationale.

Net diff: ~9 KB of meaningful changes plus the duplicated CSV/Python content (which was already present once under src/).

Verification

On a fresh Windows clone of this branch:

PS> cd .claude/skills/ui-ux-pro-max
PS> python scripts/search.py "fintech crypto modern" --design-system
# returns the full design system box (pattern, style, colors, typography, ...)

The sync script was also exercised:

bash scripts/sync-skill-assets.sh
# Syncing data/    -> .../skills/ui-ux-pro-max/data
# Syncing scripts/ -> .../skills/ui-ux-pro-max/scripts
# Done. (no git diff after — idempotent)

Trade-off

Duplicating ~1.8 MB of CSV/Python in the repo in exchange for cross-platform install correctness. The duplication is fenced behind a one-line sync command, matching the precedent already set by cli/assets/ in this repo.

Test plan

• CI Claude Review passes
• Reviewer runs python scripts/search.py "..." --design-system from inside .claude/skills/ui-ux-pro-max/ on Windows (or with core.symlinks=false) and confirms output
• Reviewer runs bash scripts/sync-skill-assets.sh (or pwsh scripts/sync-skill-assets.ps1) and confirms no spurious diff

Closes any open Windows-install issues.

[mrgoonie]

Summary: I’m deferring full maintainer review for this run because this PR is oversized for the cron-safe review budget and materially overlaps the active packaging/asset-sync queue.

Risk level: Medium

Mandatory gates:

• Duplicate/prior implementation: overlap found with Fix stack discovery in packaged skill assets #340, Fix codegen/validator bugs and a standalone-install break across four skills #346, fix CLI asset sync #355, and Replace symlinks with real files and add conversion script #368 around replacing symlinked or generated packaged assets.
• Project standards: not fully checked in this bounded pass.
• Strategic necessity: clear user value for Windows/install compatibility, but the implementation path must preserve a repeatable source-of-truth and sync workflow.
• CI/checks: not sufficient for merge decision in this pass.

Findings:

• Important: This PR changes 40 files and adds ~9.4k lines, mostly shipping real copied assets. That is too broad to safely merge without proving which files are canonical source, which files are generated/package artifacts, and what command keeps them in sync.

Verdict: DEFERRED

Next step: please add a short implementation note covering the source-of-truth files, exact sync/copy command, Windows verification path, and how this differs from the other open packaging PRs. If possible, split this into a small workflow/sync fix plus a generated-assets update so review can focus on the actual logic.