Skip to content

Add product site system generator#343

Draft
ShivamGupta42 wants to merge 2 commits into
nextlevelbuilder:mainfrom
ShivamGupta42:codex/product-site-systems
Draft

Add product site system generator#343
ShivamGupta42 wants to merge 2 commits into
nextlevelbuilder:mainfrom
ShivamGupta42:codex/product-site-systems

Conversation

@ShivamGupta42

Copy link
Copy Markdown

Summary

  • Add product-site architecture, page-family, and section-pattern datasets.
  • Add --site-system CLI mode for sitemap, page matrix, evidence gates, and Claude Design prompt packs.
  • Update generated skill templates to route product websites and feature/pricing/use-case pages through --site-system.
  • Fix generated install script paths for local/global installs and non-skills/ platforms such as Copilot and Kiro.
  • Add validation gates for source/package sync, metadata drift, template paths, generated installs, and Python CLI behavior.

Review/Fix Loop

Completed 3 review cycles with zero remaining P0/P1 findings.

  • Cycle 1 fixed generated install paths, cache-safe sync validation, and site-system persisted path mismatch.
  • Cycle 2 fixed JSON mode with --persist so stdout remains parseable JSON.
  • Cycle 3 fresh review found zero P0/P1 findings.

Deferred P2: git diff --check reports trailing whitespace in synced packaged CSV/script asset diffs. This is not fixed in this loop by design.

Validation

  • cd cli && bun run test
  • Python unit tests: 7 passing
  • Sync, metadata, template, generated-install validators passing
  • Generated install script paths execute for Claude, Codex, Copilot, and Kiro
  • --site-system -f json --persist stdout parses as JSON, with confirmation on stderr

@mrgoonie

Copy link
Copy Markdown
Contributor

Summary: I’m deferring this PR in the cron-safe maintainer lane because it is too large and appears to add a whole product-site generator rather than a narrow fix.

Decision: deferred / needs focused product-scope review

Evidence:

  • Scope is 80 changed files with +2,554/-958 lines.
  • The title says “Add product site system generator,” which is a broad new capability and likely needs source-of-truth, generated artifact, and roadmap review before code-level approval.
  • Current cron policy defers PRs over 20 changed files or 800 additions to avoid shallow approvals of broad changes.

Next step: please narrow the PR or add a maintainer-ready design note explaining the intended source of truth, generated files, commands to reproduce outputs, tests/validation, and why this generator belongs in this repo’s product direction. After that, a focused maintainer review can check implementation details.

@mrgoonie mrgoonie added agent:github-maintain Processed by github-maintain automation maintain:deferred Deferred by maintain workflow pr:oversized Too large for cron-safe review budget labels Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:github-maintain Processed by github-maintain automation maintain:deferred Deferred by maintain workflow pr:oversized Too large for cron-safe review budget

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants