feat(release): add semantic release automation#375
Conversation
|
Summary: This PR is the right direction for the release/publishing gap, but it is not merge-ready because the release job can publish npm using an unverified package and the repo CI is still red on an existing missing-file workflow. Risk level: High Mandatory gates:
Findings:
Verdict: REQUEST_CHANGES |
|
Summary: I re-reviewed the updated semantic-release PR after the new head SHA. It improves the scope by documenting that this only creates GitHub releases and no longer claims npm publishing, but it is still not merge-ready because the generated release tag would still omit the built CLI package artifact and the repository CI remains red.nnRisk level: MediumnnMandatory gates:n- Duplicate/prior implementation: overlap remains with #349 and release/package issues #353/#362; this PR is still the cleaner semantic-release path, but it does not solve npm distribution by itself.n- Project standards: issue found — release/version metadata is updated, but the release workflow does not verify or attach the built CLI package contents.n- Strategic necessity: clear value — automated GitHub releases and changelog/version sync are useful foundation work for the stale package/release gap.n- CI/checks: failing — build-linux is still failing on the missing environment.yml workflow.nnFindings:n- Important: |
clark-cant
left a comment
There was a problem hiding this comment.
Re-review after new commits: CI blocker resolved (conda workflow removed), npm publishing explicitly disabled, README updated with release docs. The remaining concern about CLI artifacts not being attached to GitHub releases is a nice-to-have follow-up, not a blocker for metadata-only semantic-release. Approving as merge-ready foundation work.
Summary
mainand beta prereleases fromdevuipro-cli, creates GitHub releases, and updates changelog/version filesskill.json, Claude plugin metadata, marketplace metadata, and CLI manifestsNPM_TOKENRelease behavior
dev-> beta prerelease, npmbetadist-tag, GitHub prereleasemain-> stable release, npmlatestdist-tag, GitHub releaseVerification
node --check scripts/sync-release-version.mjsnode -e "JSON.parse(require('fs').readFileSync('.releaserc.json','utf8'))"node scripts/sync-release-version.mjs 9.8.7-beta.1then verified all 7 version fields changed2.5.0git diff --checkNotes
NPM_TOKENwith publish access touipro-clibefore the workflow can publish npm packages.bun; the workflow installs Bun viaoven-sh/setup-bun.