Feat/update styles data#381
Conversation
- 添加新设计风格和关键词 - 优化设计系统变量和实现清单 - 更新颜色方案和性能指标
|
Summary: I’m deferring this PR from the cron-safe maintainer lane because it is far beyond the bounded review budget and mixes generated documentation/site output with source data changes. Decision: deferred / needs narrowing Evidence:
Next step: please split this into a reviewable lane. A good first PR would update only the canonical style data plus the documented generator/smoke-check output, with a short PR description explaining the generation command and how maintainers can reproduce the |
mrgoonie
left a comment
There was a problem hiding this comment.
Summary: I reviewed this as a bounded maintainer pass. The styles.csv edits are small, but the PR also adds ~53k lines / 87 static HTML/CSS/JS docs files without any PR description, generation source, or maintenance contract.
Mandatory gates:
- Duplicate/prior implementation: unclear; existing history already has a docs/styles showcase lineage, but this PR does not explain how these generated docs relate to the repo source of truth.
- Project standards: CLAUDE.md says src/ui-ux-pro-max/ is the source of truth, and templates/data/assets should be edited/synced from there.
- Strategic necessity: updating style rows is useful; committing tens of thousands of generated showcase lines is not justified in this PR.
Requested changes:
- Narrow this PR to the actual source-of-truth change in src/ui-ux-pro-max/data/styles.csv, or explain and document why the generated docs/ showcase must be committed here.
- If the docs/ files are required, add the generator/source workflow and validation command so maintainers can reproduce them. Right now the repo gets a huge static artifact dump with no provenance.
- Keep generated/package mirrors in sync only through the documented source-of-truth workflow; do not mix unrelated docs relocation/static site output with a styles data update.
Verdict: Request changes. The data update can be reviewed once the generated artifact dump is removed or made reproducible and justified.
|
Cron maintainer follow-up: PR #381 is unchanged at head |
|
Cron maintainer recheck: keeping this PR deferred/blocked for size and scope. Current head |
|
Cron maintainer pass: deferring deep review because this PR is far beyond the cron-safe review budget (+53,431/-20 across 89 files, mostly generated docs HTML) and GitHub cannot serve the diff ( Please split this into a narrow PR with source-of-truth changes first (for example just |
|
Cron maintainer review: deferring PR #381 again as oversized and not merge-ready for the cron-safe lane. GitHub refuses to serve the diff because it exceeds 20,000 lines, and metadata shows 89 changed files with +53,431/-20 lines, mostly generated |
|
Cron maintainer recheck: PR #381 is unchanged at head |
|
Cron maintainer recheck: PR #381 is still unchanged at head Keeping this deferred/blocked. Please split the canonical |
|
Cron maintainer recheck: PR #381 is still unchanged at head No merge attempt is valid here. Please split to a narrow source-of-truth |
No description provided.