Skip to content

Feat/update styles data#381

Open
easterCat wants to merge 6 commits into
nextlevelbuilder:mainfrom
easterCat:feat/update-styles-data
Open

Feat/update styles data#381
easterCat wants to merge 6 commits into
nextlevelbuilder:mainfrom
easterCat:feat/update-styles-data

Conversation

@easterCat

Copy link
Copy Markdown

No description provided.

@mrgoonie

Copy link
Copy Markdown
Contributor

Summary: I’m deferring this PR from the cron-safe maintainer lane because it is far beyond the bounded review budget and mixes generated documentation/site output with source data changes.

Decision: deferred / needs narrowing

Evidence:

  • This PR changes 89 files with +53,431/-20 lines.
  • Most of the diff adds large generated HTML pages under docs/, while also changing canonical source data in src/ui-ux-pro-max/data/styles.csv.
  • The PR body is empty, so there is no source-of-truth note, generation command, or verification evidence tying the generated docs output back to the style data change.

Next step: please split this into a reviewable lane. A good first PR would update only the canonical style data plus the documented generator/smoke-check output, with a short PR description explaining the generation command and how maintainers can reproduce the docs/ artifacts. After that, the generated site refresh can be reviewed separately.

@mrgoonie mrgoonie added agent:github-maintain Processed by github-maintain automation maintain:deferred Deferred by maintain workflow pr:oversized Too large for cron-safe review budget labels Jun 23, 2026

@mrgoonie mrgoonie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: I reviewed this as a bounded maintainer pass. The styles.csv edits are small, but the PR also adds ~53k lines / 87 static HTML/CSS/JS docs files without any PR description, generation source, or maintenance contract.

Mandatory gates:

  • Duplicate/prior implementation: unclear; existing history already has a docs/styles showcase lineage, but this PR does not explain how these generated docs relate to the repo source of truth.
  • Project standards: CLAUDE.md says src/ui-ux-pro-max/ is the source of truth, and templates/data/assets should be edited/synced from there.
  • Strategic necessity: updating style rows is useful; committing tens of thousands of generated showcase lines is not justified in this PR.

Requested changes:

  1. Narrow this PR to the actual source-of-truth change in src/ui-ux-pro-max/data/styles.csv, or explain and document why the generated docs/ showcase must be committed here.
  2. If the docs/ files are required, add the generator/source workflow and validation command so maintainers can reproduce them. Right now the repo gets a huge static artifact dump with no provenance.
  3. Keep generated/package mirrors in sync only through the documented source-of-truth workflow; do not mix unrelated docs relocation/static site output with a styles data update.

Verdict: Request changes. The data update can be reviewed once the generated artifact dump is removed or made reproducible and justified.

@mrgoonie

Copy link
Copy Markdown
Contributor

Cron maintainer follow-up: PR #381 is unchanged at head 3dadec945507cfbaadbaf5d52e5f789b5f6c42f4 and remains blocked/deferred. Current metadata is still 89 files with +53,431/-20, mixing a small src/ui-ux-pro-max/data/styles.csv edit with a large generated docs/ static-site dump and no PR body/generation command. Please narrow to source-of-truth data changes first, or document the generator and reproducible validation path for the docs artifacts before requesting another review.

@mrgoonie

Copy link
Copy Markdown
Contributor

Cron maintainer recheck: keeping this PR deferred/blocked for size and scope. Current head 3dadec945507cfbaadbaf5d52e5f789b5f6c42f4 changes 89 files with +53,431/-20 lines, mostly generated docs/*.html pages plus docs/shared.*, while the actual source-of-truth data change is only src/ui-ux-pro-max/data/styles.csv. GitHub cannot even return the diff because it exceeds the 20,000-line diff cap, so this is not reviewable in the cron-safe lane. Please split this into a narrow PR for styles.csv metadata updates first, and move generated docs/site output into a separate PR or generation workflow after the canonical data change is accepted.

@mrgoonie

Copy link
Copy Markdown
Contributor

Cron maintainer pass: deferring deep review because this PR is far beyond the cron-safe review budget (+53,431/-20 across 89 files, mostly generated docs HTML) and GitHub cannot serve the diff (PullRequest.diff too_large). It also has merge conflicts (mergeStateStatus=DIRTY) and an empty PR body, so there is no reviewable scope/acceptance explanation.

Please split this into a narrow PR with source-of-truth changes first (for example just src/ui-ux-pro-max/data/styles.csv plus the generator/template that produces docs), then put generated docs in a separate mechanical PR if they are still needed. Include a short body explaining what changed, how the docs were generated, and the smoke command used to verify the styles data. Until then this should stay deferred/blocked rather than merged.

@mrgoonie

Copy link
Copy Markdown
Contributor

Cron maintainer review: deferring PR #381 again as oversized and not merge-ready for the cron-safe lane. GitHub refuses to serve the diff because it exceeds 20,000 lines, and metadata shows 89 changed files with +53,431/-20 lines, mostly generated docs/*.html plus docs/shared.* and src/ui-ux-pro-max/data/styles.csv. The PR also has an empty body and mergeStateStatus: DIRTY, so there is no reviewable rationale, no source-of-truth mapping, and no merge path in this run.nnPlease split this into small PRs. Start with the canonical src/ui-ux-pro-max/data/styles.csv change only, explain exactly which styles are being added/changed, and include the command or script used to regenerate any docs output. Generated docs/*.html pages should land only after the source data change is reviewable and the generation path is reproducible.

@mrgoonie

Copy link
Copy Markdown
Contributor

Cron maintainer recheck: PR #381 is unchanged at head 3dadec945507cfbaadbaf5d52e5f789b5f6c42f4, still 89 changed files / +53,431/-20, still empty body, and still mergeStateStatus=DIRTY. GitHub also still refuses the diff with PullRequest.diff too_large, so this remains outside the cron-safe review lane. No merge attempt is valid here. Please split to a narrow source-of-truth src/ui-ux-pro-max/data/styles.csv change first, with the generation/smoke command documented; generated docs/site artifacts should be a separate reproducible PR.

@mrgoonie

Copy link
Copy Markdown
Contributor

Cron maintainer recheck: PR #381 is still unchanged at head 3dadec945507cfbaadbaf5d52e5f789b5f6c42f4 and remains outside the cron-safe review lane. Metadata is still 89 changed files with +53,431/-20 lines, mostly generated docs/*.html plus docs/shared.*, while the source-of-truth edit is only src/ui-ux-pro-max/data/styles.csv. The PR body is still empty and mergeStateStatus=DIRTY, so there is no reproducible generation path or merge path to validate.

Keeping this deferred/blocked. Please split the canonical src/ui-ux-pro-max/data/styles.csv change into a narrow PR with a short description of the style rows changed and the command used to regenerate/check any docs output. Generated docs/site artifacts should be a separate mechanical PR after the source data is reviewable.

@mrgoonie

Copy link
Copy Markdown
Contributor

Cron maintainer recheck: PR #381 is still unchanged at head 3dadec945507cfbaadbaf5d52e5f789b5f6c42f4, still 89 changed files / +53,431/-20, and still mergeStateStatus=DIRTY. The diff remains too large for a bounded cron-safe review and the PR body still does not explain the generated docs workflow.

No merge attempt is valid here. Please split to a narrow source-of-truth src/ui-ux-pro-max/data/styles.csv change first, with the style rows changed and generation/smoke command documented. Generated docs/*.html / docs/shared.* artifacts should be a separate reproducible mechanical PR after the source data is reviewable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:github-maintain Processed by github-maintain automation maintain:deferred Deferred by maintain workflow pr:oversized Too large for cron-safe review budget

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants