fix(collab): harden workspace authority recovery and revocation - #6406
Closed
lefarcen wants to merge 3 commits into
Closed
fix(collab): harden workspace authority recovery and revocation#6406lefarcen wants to merge 3 commits into
lefarcen wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
While validating Workspace collaboration end to end, we reproduced three authority gaps on the
feat/workspace-teamintegration branch:These bugs either retain access after revocation or strand authorized users in a stale fail-closed state. This follow-up keeps Team authorization fail-closed while making revocation and recovery converge deterministically.
What users will see
Surface area
apps/weborapps/desktop(including Electron menu bar)odsubcommand or flag, newtools-dev/tools-packflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates/, orcraft/, or change to the skills protocolTRANSLATIONS.mdfor the locale workflow)package.jsonScreenshots
No new visual surface. Real two-account Chrome acceptance is tracked separately for the existing project viewer states.
Bug fix verification
apps/daemon/tests/collab/workspace-projects-hub-wiring.test.tsapps/daemon/tests/collab/workspace-projects-reconcile-http.test.tsapps/web/tests/useProjectWorkspaceScope.test.tsxapps/web/tests/useProjectWorkspaceScope.workspace-identity.test.tsxapps/web/tests/components/FileViewer.test.tsxapps/web/tests/components/DesignKitView.test.tsxapps/web/tests/components/ProjectView.run-workspace-identity.test.tsxapps/web/tests/providers/project-workspace-transport-scope.test.tsValidation
pnpm --filter @open-design/web typecheckpnpm guardpnpm typecheckandgit diff --check