fix(web): show full descriptions for expanded skills - #7032
Conversation
|
@kuigoo Thanks for opening this as a draft — the bug write-up and validation notes are clear. We'll hold off on a full review until it's marked ready for review. |
|
@kuigoo Thanks for marking this ready for review. 🧪 This PR has user-visible UI changes that will need a manual QA pass before merge — please hold off self-merging for now; we'll loop QA in once it's merge-ready (and after design sign-off). |
|
@kuigoo Thanks for adding the before/after screenshots — they make the layout fix much clearer. |
nettee
left a comment
There was a problem hiding this comment.
@kuigoo I reviewed the expanded skill-row CSS and regression coverage in apps/web/src/styles/viewer/templates-plugins.css and apps/web/tests/styles/settings-polish.test.ts. The new expanded-state rules correctly override the global fixed button height, preserve the collapsed ellipsis behavior, and allow wrapped descriptions to sit above the SKILL.md detail. The live PR checks are green, including workspace tests, settings UI P0, visual checks, and the static gate; git diff --check also passes. The prepared checkout had no installed dependencies, so I could not rerun Vitest locally. This is a focused, well-documented fix—thanks for including the before/after evidence and validation notes!

































































Fixes #7031
Why
I hit this while reviewing a skill with a long description in Integrations > Skills. Expanding the row reveals its SKILL.md content and bundled files, but the collapsed row's single-line ellipsis styles continue to constrain the summary description. The fixed-height summary control also cannot grow with wrapped text, which can make the summary overlap the detail content.
What users will see
Collapsed skill rows keep the current compact one-line ellipsis. Expanded rows wrap the complete description, grow with the content, and keep the SKILL.md detail below the summary without overlap.
Surface area
apps/weborapps/desktop(including Electron menu bar)odsubcommand or flag, newtools-dev/tools-packflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates/, orcraft/, or change to the skills protocolpackage.jsonScreenshots
See the before/after comparison in this PR comment.
Bug fix verification
apps/web/tests/styles/settings-polish.test.tsbrand-extractdescription wraps without horizontal clipping or overlap with the SKILL.md detail.Validation
pnpm guardpnpm typecheckpnpm --filter @open-design/web exec vitest run -c vitest.config.ts tests/styles/settings-polish.test.ts --maxWorkers=2pnpm --filter @open-design/web test— 624 test files passed, 6562 tests passed, 1 expected failure, 11 skippedpnpm --filter @open-design/web buildgit diff --checkbrand-extractskill