fix(workspace): restore last selection after restart by lefarcen · Pull Request #7067 · nexu-io/open-design

lefarcen · 2026-08-18T11:19:03Z

Why

QA found that quitting and reopening the client did not return users to the workspace they had last selected. The web client kept its selection only in tab-scoped sessionStorage, while the daemon's selection store was no longer updated, so a cold client fell back to Personal/default instead of the user's last workspace.

The same investigation found that workspace resolution still depended on Vela's account-global /api/v1/workspaces/current endpoint. That state cannot represent multiple tabs or clients using different workspaces, so this PR removes that dependency and keeps request authority explicitly workspace-scoped.

What users will see

After selecting a workspace, quitting Open Design, and reopening it, the client returns to that workspace when the membership is still active. If the saved workspace was removed or deleted, startup safely falls back to an available workspace.

Already-open tabs remain independently scoped: the saved workspace is only a cold-start preference and never authorizes data-plane requests.

Surface area

UI — new page / dialog / panel / menu item / setting / empty state in apps/web or apps/desktop (including Electron menu bar)
Keyboard shortcut — new or changed
CLI / env var — new od subcommand or flag, new tools-dev / tools-pack flag, or new OD_* env var
API / contract — new /api/* endpoint, new SSE event, or changed shape in packages/contracts
Extension point — new entry under skills/, design-systems/, design-templates/, or craft/, or change to the skills protocol
i18n keys — added new translation keys (see TRANSLATIONS.md for the locale workflow)
New top-level dependency — adding any new entry to the root package.json (dependencies or devDependencies); workspace-package package.json files are out of scope. Include a paragraph on what we get vs. what bytes we ship (see CONTRIBUTING.md → Code style)
Default behavior change — changes what existing users experience without opting in (default model, default setting, file/SQLite schema, auto-network on startup, auto-install)
None — internal refactor, docs, tests, or translation update only

Screenshots

Not applicable: this changes restart selection behavior without adding or visually changing a UI entry point.

Bug fix verification

Test path that reproduces the bug: apps/web/tests/useWorkspaceContext.cache.test.tsx (restores the daemon-saved workspace when a new client session has no tab selection)
Did the test go red on main and green on this branch? Yes. On main, the cold client context remained null/fell through instead of selecting the saved Team workspace; on this branch all four tests pass.
Cross-process restart coverage: e2e/tests/collab/workspace-switch-and-billing.test.ts persists a Team selection, restarts the daemon over the same data root, and verifies both restoration and stale-membership cleanup.

Validation

corepack pnpm install --frozen-lockfile
corepack pnpm guard
corepack pnpm typecheck
corepack pnpm --filter @open-design/daemon exec vitest run -c vitest.config.ts tests/vela-workspace-context.test.ts tests/collab/active-workspace-selection.test.ts tests/collab/workspace-multi-client-scope.test.ts tests/collab/workspace-scope.test.ts tests/collab-presence-routes.test.ts tests/collab/workspace-switch-warms-caches.test.ts tests/workspace-context-authority-server-wiring.test.ts — 111 passed
corepack pnpm --filter @open-design/web exec vitest run -c vitest.config.ts tests/useWorkspaceContext.cache.test.tsx — 4 passed
corepack pnpm --filter @open-design/e2e exec vitest run -c vitest.config.ts tests/amr/turn.test.ts tests/collab/headerless-mutation.test.ts tests/collab/new-account-default-workspace.test.ts tests/collab/reconcile-unbound-authority.test.ts tests/collab/team-project-catalog.test.ts tests/collab/workspace-invite-flow.test.ts tests/collab/workspace-skill-resource-isolation.test.ts tests/collab/workspace-switch-and-billing.test.ts — 20 passed
Repository scan for /api/v1/workspaces/current, workspaces/current, and WORKSPACE_CURRENT_PATH — 0 matches

lefarcen · 2026-08-18T11:31:56Z

🧪 This PR has changes that need a manual QA pass before merge — please hold off self-merging for now; we'll loop QA in once it's merge-ready (and design/product have signed off, where applicable).

github-actions · 2026-08-18T11:35:19Z

Visual regression review

Head: 04c4bbb · Base: 42faa84

0 changed · 49 unchanged · 0 new without baseline · 0 failed

Unchanged cases

Case	Main	PR	Diff
visual-avatar-local-agent-list _{0 px (0.00%)}
visual-avatar-local-agent-list-panel _{0 px (0.00%)}
visual-avatar-menu _{0 px (0.00%)}
visual-avatar-menu-panel _{0 px (0.00%)}
visual-avatar-open-design-model-picker _{0 px (0.00%)}
visual-critical-settings _{0 px (0.00%)}
visual-critical-workspace _{0 px (0.00%)}
visual-critical-workspace-preview _{0 px (0.00%)}
visual-design-system-detail _{0 px (0.00%)}
visual-design-systems _{0 px (0.00%)}
visual-home _{0 px (0.00%)}
visual-home-catalog _{0 px (0.00%)}
visual-home-context-picker _{0 px (0.00%)}
visual-home-context-picker-popover _{0 px (0.00%)}
visual-home-plugin-filter _{0 px (0.00%)}
visual-home-plugin-use-staged _{0 px (0.00%)}
visual-home-plugin-use-with-query _{0 px (0.00%)}
visual-home-staged-attachment _{0 px (0.00%)}
visual-integrations _{0 px (0.00%)}
visual-integrations-mcp _{0 px (0.00%)}

Visual diff is advisory only and does not block merging.

Siri-Ray

@lefarcen Thanks for the careful workspace-restoration work. I verified the persisted restart-default flow, exact request authority, stale-membership recovery, and the focused daemon/web/e2e suites. The restoration path looks solid; I’m leaving one non-blocking follow-up on the directory-only seat sentinel, where the entry gate and invite dialog currently disagree.