Skip to content

fix(web): align low-balance dialog action styles - #7138

Open
open-design-crew[bot] wants to merge 1 commit into
mainfrom
codex/fix-low-balance-dialog-actions
Open

fix(web): align low-balance dialog action styles#7138
open-design-crew[bot] wants to merge 1 commit into
mainfrom
codex/fix-low-balance-dialog-actions

Conversation

@open-design-crew

Copy link
Copy Markdown
Contributor

Summary

  • apply one shared action-button shape to both CTAs in the low-balance dialog
  • preserve the primary/secondary fill hierarchy while using the same pill radius

Problem

The adjacent Start anyway and Top up buttons used different corner-radius treatments, making the dialog action group look inconsistent. The supplied reproduction screenshot is attached in a follow-up comment.

Testing

  • pnpm --filter @open-design/web exec vitest run tests/components/AmrLowBalanceDialog.test.tsx (2 tests passed)
  • git diff --check (passed)
  • pnpm --filter @open-design/web run typecheck (blocked by existing stale workspace package outputs; failures are in unrelated contracts/analytics and other modules)

@open-design-crew

Copy link
Copy Markdown
Contributor Author

Before: the low-balance dialog shows inconsistent corner-radius treatments between the two adjacent action buttons.

codex-clipboard-0e8ebc27-7458-4f22-a5cf-5dfbe7f96be5.png

@lefarcen
lefarcen requested a review from mrcfps August 19, 2026 15:32
@lefarcen lefarcen added size/XS PR changes <20 lines risk/medium Medium risk: regular code changes type/bugfix Bug fix skip-validation Maintainer override: bot will not auto-add needs-validation on this PR. labels Aug 19, 2026
@lefarcen

Copy link
Copy Markdown
Contributor

The problem statement and testing notes are already clear. Could you add the Surface area section and tick UI for this one, since the change updates the low-balance dialog action styling?,workdir:/,yield_time_ms:10000,max_output_tokens:4000}},{

@mrcfps mrcfps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@app/open-design-crew thanks for the tidy visual fix.

Verified the two-button radius mismatch: default Button uses --radius-sm while variant="primary" already pills, so sharing .action { border-radius: var(--radius-pill) } under .footerActions is the right local override. Specificity beats .button, the primary/secondary fill hierarchy stays intact, and click/testid behavior is unchanged.

Nice, focused CSS-module change — appreciate keeping it surgical.

🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.

@github-actions

Copy link
Copy Markdown
Contributor

Visual regression review

Head: e3bfd03 · Base: 057b0f4

0 changed · 49 unchanged · 0 new without baseline · 0 failed

Unchanged cases
Case Main PR Diff
visual-avatar-local-agent-list
0 px (0.00%)
main pr diff
visual-avatar-local-agent-list-panel
0 px (0.00%)
main pr diff
visual-avatar-menu
0 px (0.00%)
main pr diff
visual-avatar-menu-panel
0 px (0.00%)
main pr diff
visual-avatar-open-design-model-picker
0 px (0.00%)
main pr diff
visual-critical-settings
0 px (0.00%)
main pr diff
visual-critical-workspace
0 px (0.00%)
main pr diff
visual-critical-workspace-preview
0 px (0.00%)
main pr diff
visual-design-system-detail
0 px (0.00%)
main pr diff
visual-design-systems
0 px (0.00%)
main pr diff
visual-home
0 px (0.00%)
main pr diff
visual-home-catalog
0 px (0.00%)
main pr diff
visual-home-context-picker
0 px (0.00%)
main pr diff
visual-home-context-picker-popover
0 px (0.00%)
main pr diff
visual-home-plugin-filter
0 px (0.00%)
main pr diff
visual-home-plugin-use-staged
0 px (0.00%)
main pr diff
visual-home-plugin-use-with-query
0 px (0.00%)
main pr diff
visual-home-staged-attachment
0 px (0.00%)
main pr diff
visual-integrations
0 px (0.00%)
main pr diff
visual-integrations-mcp
0 px (0.00%)
main pr diff

Visual diff is advisory only and does not block merging.

@lefarcen

Copy link
Copy Markdown
Contributor

This is merge-ready from the review side, but it still needs a manual QA pass before merge. Also, the PR body is still missing Surface area (please tick UI) and a short bug-fix verification note describing how you confirmed the radius mismatch is fixed.

@lefarcen
lefarcen requested a review from ivy-ting August 19, 2026 15:42
@lefarcen lefarcen added needs-validation Runtime change detected; needs human or /explore agent validation. and removed skip-validation Maintainer override: bot will not auto-add needs-validation on this PR. labels Aug 19, 2026
@ivy-ting

Copy link
Copy Markdown
Contributor

@open-design-crew

Thanks for the contribution. I completed QA validation for this PR.

QA Acceptance Record

Scope:

  • Low-balance dialog action styling and existing button behavior.

Verified:

  • Both actions render with the same pill radius while preserving the primary/secondary hierarchy.
  • Focused component and workflow regression tests passed (82/82).
  • The current-head CI is green, and the proceed action was verified in a real browser.

Risks / notes:

  • No blocking issues found.

Conclusion:

  • Accepted.

@ivy-ting ivy-ting added validated Runtime change validated (via /explore Pass or manual QA). and removed needs-validation Runtime change detected; needs human or /explore agent validation. labels Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/medium Medium risk: regular code changes size/XS PR changes <20 lines type/bugfix Bug fix validated Runtime change validated (via /explore Pass or manual QA).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants