fix(web): flatten message center list - #7231
Conversation
Siri-Ray
changed the title
lefarcen
added
size/M
PerishCode
left a comment
PerishCode
left a comment
There was a problem hiding this comment.
@Siri-Ray This cleanly removes the message-center filter controls and state while preserving the combined read/unread feed, unread emphasis, per-message read behavior, and Mark all read behavior. I reviewed every changed range and the focused regression coverage; the live web, workspace, static, and UI checks are green. Nice focused fix and a clear test update—thank you for keeping the behavior change compact.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.
|
🧪 This PR changes a user-facing message-center flow, so it needs a manual QA pass before merge — please hold off self-merging for now; we'll loop QA in once it's merge-ready. |
lefarcen
added
the
needs-validation
Visual regression reviewHead: 12 changed · 39 unchanged · 0 new without baseline · 0 failed Changed cases
Unchanged cases
Visual diff is advisory only and does not block merging. |
AmyShang-alt
added
the
backport release/v0.20.2
![open-design-crew[bot]](https://avatars.githubusercontent.com/in/4197780?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA passed on Electron at current head (0f0ae4a). Verified the message center renders read and unread notifications in one flat list, removes the All/Unread/Read filters and bulk Mark all read action, and preserves per-message read behavior. Electron, web, and daemon launched successfully in an isolated runtime.
AmyShang-alt
added
validated
|
Successfully created backport PR for |
* fix(web): flatten message center list * fix(web): polish message center states --------- (cherry picked from commit 6b9c6a0) Co-authored-by: Ray Xi <2667192167@qq.com> Co-authored-by: elifive555555 <296440099+elifive555555@users.noreply.github.com>
5 participants
Why
Plane dogfooding item OPEND-2175 asks for the message center to remove its All, Unread, and Read tabs and present notifications in one list. The current three-way filter adds a navigation choice to a small feed and can hide already-read context when users revisit an announcement.
Follow-up dogfooding also found that the bulk "Mark all read" row added unnecessary empty chrome, the header divider touched the panel edges, unread styling was too heavy, and expanding a message could visibly shift the layout.
What users will see
The message center now shows read and unread messages together in one flat list without filter tabs or a bulk "Mark all read" action. Unread messages use a compact red dot, the header divider is inset from both edges, hover backgrounds keep rounded corners, and expanding a message preserves its typography and horizontal layout.
Per-message read behavior remains available: opening an unread message marks that message as read.
Surface area
apps/webodsubcommand or flag, newtools-dev/tools-packflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates, orcraft/, or change to the skills protocolpackage.jsonScreenshots
Not attached. The message-center panel was verified through a local
tools-devbrowser run with the live multi-message feed, including read/unread, hover, and expanded states.Bug fix verification
apps/web/tests/components/MessageCenter.test.tsxValidation
corepack pnpm --filter @open-design/web exec vitest run -c vitest.config.ts tests/components/MessageCenter.test.tsx --maxWorkers=1(21 passed)corepack pnpm guardcorepack pnpm typecheckgit diff --checktools-devbrowser verification of the message-center panel