Skip to content

Nf core template merge 3.3.1 - #893

Merged
d4straub merged 10 commits into
nf-core:devfrom
d4straub:nf-core-template-merge-3.3.1
Jun 11, 2025
Merged

Nf core template merge 3.3.1#893
d4straub merged 10 commits into
nf-core:devfrom
d4straub:nf-core-template-merge-3.3.1

Conversation

@d4straub

@d4straub d4straub commented Jun 5, 2025

Copy link
Copy Markdown
Collaborator

Merging template update 2.3.1.

Tests are working. I simply made the previous/primal implementation of nf-test in ampliseq work with the current template 3.3.1 setting. That means that the snapshots are not generated with nf-test but manually with selected files.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@d4straub

d4straub commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator Author

The following errors occur in tests:

'-profile test_failed' 
ERROR ~ Error executing process > 'NFCORE_AMPLISEQ:AMPLISEQ:QIIME2_ANCOM:QIIME2_ANCOMBC_TAX (treatment1--2)'
ERROR ~ Error executing process > 'NFCORE_AMPLISEQ:AMPLISEQ:QIIME2_ANCOM:QIIME2_ANCOMBC_TAX (treatment1--3)'
'-profile test_sintax'
ERROR ~ Error executing process > 'NFCORE_AMPLISEQ:AMPLISEQ:SUMMARY_REPORT (1)'
    > Command exit status:
    >   125
docker: failed to register layer: write /usr/local/libexec/gcc/x86_64-conda-linux-gnu/13.1.0/cc1plus: no space left on device

'-profile test_failed' also failed in the previous attempt in #859, but '-profile test_sintax' succeeded there.

@d4straub d4straub moved this from Todo to In Progress in meta-omics nf-test fest Jun 11, 2025
@d4straub d4straub self-assigned this Jun 11, 2025
@brovolia brovolia self-assigned this Jun 11, 2025
@d4straub

Copy link
Copy Markdown
Collaborator Author

By increasing the number of shards '-profile test_sintax' passes now.

@d4straub

d4straub commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator Author

'-profile test_failed' still fails with the mysterious
Process `NFCORE_AMPLISEQ:AMPLISEQ:QIIME2_ANCOM:QIIME2_ANCOMBC_TAX (treatment1--3)` terminated with an error exit status (1)

@d4straub
d4straub marked this pull request as ready for review June 11, 2025 10:13
@d4straub d4straub moved this from In Progress to Needs review in meta-omics nf-test fest Jun 11, 2025
@jfy133 jfy133 moved this from Needs review to Under Review in meta-omics nf-test fest Jun 11, 2025

@jfy133 jfy133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments but overall LGTM, fine workaround for the syntax differenece in the .nf.test files

Comment thread .github/actions/nf-test/action.yml Outdated
Comment thread conf/test_failed.config
ignore_failed_trimming = true
ignore_empty_input_files = true
ignore_failed_filtering = true
ancombc = true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on purpose?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because for an unknown reason that makes the test fail. That param is also activated (and succeeding) in profile test, so I am not overly concerned about it fr now.

Comment thread nf-test.config Outdated
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
@d4straub

Copy link
Copy Markdown
Collaborator Author

Thanks for the review!

@d4straub
d4straub merged commit 4d71dd7 into nf-core:dev Jun 11, 2025
33 checks passed
@github-project-automation github-project-automation Bot moved this from Under Review to Done in meta-omics nf-test fest Jun 11, 2025
@d4straub
d4straub deleted the nf-core-template-merge-3.3.1 branch June 11, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants