Nf core template merge 3.3.1 - #893
Conversation
|
The following errors occur in tests: '-profile test_failed' also failed in the previous attempt in #859, but '-profile test_sintax' succeeded there. |
|
By increasing the number of shards '-profile test_sintax' passes now. |
|
'-profile test_failed' still fails with the mysterious |
jfy133
left a comment
There was a problem hiding this comment.
A couple of comments but overall LGTM, fine workaround for the syntax differenece in the .nf.test files
| ignore_failed_trimming = true | ||
| ignore_empty_input_files = true | ||
| ignore_failed_filtering = true | ||
| ancombc = true |
There was a problem hiding this comment.
Yes, because for an unknown reason that makes the test fail. That param is also activated (and succeeding) in profile test, so I am not overly concerned about it fr now.
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
|
Thanks for the review! |
Merging template update 2.3.1.
Tests are working. I simply made the previous/primal implementation of nf-test in ampliseq work with the current template 3.3.1 setting. That means that the snapshots are not generated with nf-test but manually with selected files.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).