Skip to content

Add min boot param - #913

Merged
d4straub merged 3 commits into
nf-core:devfrom
zmudge3:add-minBoot-param
Sep 25, 2025
Merged

Add min boot param#913
d4straub merged 3 commits into
nf-core:devfrom
zmudge3:add-minBoot-param

Conversation

@zmudge3

@zmudge3 zmudge3 commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This PR adds a new parameter, dada_min_boot, that corresponds exactly with minBoot in DADA2's assignTaxonomy method. This parameter specifies a minimum bootstrap confidence (out of 100 trials) needed in order to assign a taxonomic level. This can be helpful in order to filter out assignments for ASVs that are likely too specific. E.g. An ASV was assigned to the incorrect species with confidence 55 (0.55), which is quite low, but was assigned to the correct genus level with confidence 75 (0.75). By setting dada_min_boot to 60 (0.60) in this example, the reported assignment would be to the genus level. Users can adjust dada_min_boot based on their own observations concerning what threshold they begin to see inaccurate assignments.

This also contains a small commit to adjust the order of the read truncation parameters (truncq, trunc_qmin, trunc_rmin, trunclenf, trunclenr) in nextflow.config to match the order they appear in nextflow_schema.json. No functional difference.

@d4straub d4straub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!
All fine to me, except the parameter documentation.

Comment thread nextflow_schema.json Outdated
@zmudge3

zmudge3 commented Sep 25, 2025

Copy link
Copy Markdown
Contributor Author

Those are great points! I renamed the "Taxonomic database" section to "Taxonomic assignment" and moved dada_min_boot into there. I put it at the top of that section, but feel free to move it lower if you think it needs it.

I found one link to that section (in usage.md) and updated the link.

@d4straub d4straub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@d4straub
d4straub merged commit 6ac6f8f into nf-core:dev Sep 25, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants