Skip to content

fix: include all binners in dastool validation #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dialvarezs merged 3 commits into from
Mar 23, 2026
Merged

fix: include all binners in dastool validation #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f609e9d
fix: include all binners in dastool validation
dialvarezs Mar 23, 2026
bd7ce1e
chore: update changelog
dialvarezs Mar 23, 2026
fe0c303
Merge remote-tracking branch 'upstream/dev' into fix/dastool-check
dialvarezs Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### `Fixed`

- [#1001](https://github.com/nf-core/mag/pull/1001) - Include all binners in parameter validation for running DASTool (by @dialvarezs)

### `Dependencies`

| Tool | Previous version | New version |
Expand Down
2 changes: 1 addition & 1 deletion subworkflows/local/utils_nfcore_mag_pipeline/main.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ def validateInputParameters(hybrid) {

// Check more than one binner is run for bin refinement (required DAS by Tool)
// If the number of run binners (i.e., number of not-skipped) is more than one, otherwise throw an error
if (params.refine_bins_dastool && !([params.skip_metabat2, params.skip_maxbin2, params.skip_concoct].count(false) > 1)) {
if (params.refine_bins_dastool && !([params.skip_metabat2, params.skip_maxbin2, params.skip_concoct, params.skip_metabinner, params.skip_comebin, params.skip_semibin].count(false) > 1)) {
error('[nf-core/mag] ERROR: Bin refinement with --refine_bins_dastool requires at least two binners to be running (not skipped). Check input.')
}

Expand Down
Loading