Skip to content
Merged
Show file tree
Hide file tree
Changes from 61 commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
f4227f0
docs(coverage): add section to usage documenting how to tune the perc…
prototaxites Sep 30, 2025
9f9346b
fix(test_full): set longread_percentidentity to 85
prototaxites Sep 30, 2025
51591cc
docs: update changelog
prototaxites Sep 30, 2025
611a30c
lint: trailing whitespace
prototaxites Sep 30, 2025
9c0705a
feat: post-release version bump
prototaxites Sep 30, 2025
03e5f05
fix: bump pipeline version in all snapshots
prototaxites Sep 30, 2025
343a0c8
Apply suggestions from code review
prototaxites Sep 30, 2025
7e2b80e
Merge pull request #873 from nf-core/doc_perc_id
prototaxites Sep 30, 2025
5bcd0e9
add binner COMEBin
d4straub Oct 7, 2025
8c473e9
Fix metaspades name in baseconfig and optimise test_full
jfy133 Oct 11, 2025
c02620f
Merge branch 'dev' into optmise-full_test_resources
jfy133 Oct 11, 2025
afba873
Update CHANGELOG and allow GTDBTK to fail and be ignored
jfy133 Oct 11, 2025
b9a73db
Add PR number to changelog
jfy133 Oct 11, 2025
5df6131
Remove accidently search typo
jfy133 Oct 11, 2025
0c5be12
Apply suggestions from code review
jfy133 Oct 13, 2025
18f5303
adjust output file names
d4straub Oct 14, 2025
66e99b1
Update conf/test_full.config
jfy133 Oct 14, 2025
0d95ada
Merge pull request #878 from nf-core/optmise-full_test_resources
jfy133 Oct 14, 2025
b9f8662
Template update for nf-core/tools version 3.4.0
nf-core-bot Oct 15, 2025
5c8df5d
update output files and docs
d4straub Oct 15, 2025
45fdd71
diff for runcomebin/comebin-runcomebin
d4straub Oct 15, 2025
8e40fa2
[automated] Fix code linting
nf-core-bot Oct 15, 2025
51132da
--fix rocrate_readme_sync
d4straub Oct 15, 2025
352d6a2
apply reviewer suggestions
d4straub Oct 16, 2025
6ccca49
update comebin-runcomebin.diff
d4straub Oct 16, 2025
12c3546
[automated] Fix code linting
nf-core-bot Oct 16, 2025
913dea3
Template update for nf-core/tools version 3.4.1
nf-core-bot Oct 16, 2025
b53de9e
re-install COMEBin module
d4straub Oct 17, 2025
251c80f
merge changes
d4straub Oct 17, 2025
db30b0a
Merge pull request #875 from d4straub/add-binner-COMEBin
d4straub Oct 17, 2025
3c09f6f
Fix typo in long-read assembly mode selection when selecting HQ Nanop…
jfy133 Oct 17, 2025
8e4fa38
Update CHANGELOG.md
jfy133 Oct 17, 2025
a2829c5
Make even clearer docs that CheckM2 is a FILE not a directory
jfy133 Oct 17, 2025
321889f
Merge branch 'dev' into nf-core-template-merge-3.4.1
jfy133 Oct 17, 2025
9a77424
Fix linting
jfy133 Oct 17, 2025
4b75c59
Update default test snapshot
jfy133 Oct 17, 2025
8853bb3
Merge pull request #886 from nf-core/fix-882
jfy133 Oct 17, 2025
4703a65
Merge pull request #885 from nf-core/fix-883
jfy133 Oct 17, 2025
10d5c35
Update snapshots
jfy133 Oct 17, 2025
614741c
fix(binning): only error on bin length filter if there are bins
prototaxites Oct 22, 2025
88f8ad0
fix: use findAll, not collect
prototaxites Oct 22, 2025
b6bf460
fix: missing bracket
prototaxites Oct 22, 2025
b65789a
Update .github/workflows/release-announcements.yml
jfy133 Oct 22, 2025
75319b4
fix: catch case where there are no stats by passing empty list
prototaxites Oct 22, 2025
35c95c6
feat: update changelog
prototaxites Oct 22, 2025
5c08a45
fix: add comment and wrap long lines
prototaxites Oct 22, 2025
7b8afa4
fix: WHITESPACE
prototaxites Oct 22, 2025
e30367c
[automated] Fix code linting
nf-core-bot Oct 22, 2025
5e119a1
Update CHANGELOG for nf-core 3.4.1 changes
jfy133 Oct 23, 2025
2380df0
[automated] Fix code linting
nf-core-bot Oct 23, 2025
23586dd
Merge pull request #880 from nf-core/nf-core-template-merge-3.4.1
jfy133 Oct 23, 2025
56d2ab6
Update contributor name from '@willros' to 'William Rosenbaum'
willros Oct 24, 2025
9d441f2
Merge branch 'nf-core:dev' into dev
willros Oct 24, 2025
5e5bb0c
Update RO crate to match README
jfy133 Oct 24, 2025
19de32b
Update description field in ro-crate-metadata.json
jfy133 Oct 24, 2025
673c52d
Merge pull request #891 from willros/dev
jfy133 Oct 24, 2025
c1bbcbd
Update CHANGELOG.md
prototaxites Oct 24, 2025
6b7cb5e
Merge pull request #888 from prototaxites/fix_bin_count_error
prototaxites Oct 24, 2025
9402772
Version bump for 5.1.0 release
jfy133 Oct 24, 2025
4330d59
Fix snapshot
jfy133 Oct 25, 2025
a1341dc
Merge pull request #892 from nf-core/prerelease-version-bump-5.1.0
jfy133 Oct 25, 2025
ba3ca05
Pin GTDBTk python version in conda env to match container
jfy133 Oct 26, 2025
f14047a
Merge branch 'dev' of github.com:nf-core/mag into dev
jfy133 Oct 26, 2025
0b9ef1f
Move changelog entry for bin size filer to the right place
jfy133 Oct 26, 2025
7b8712f
Allow full tests to pull public data from AWS S3 without credentials.
jfy133 Oct 26, 2025
81a186a
Apply suggestion from @jfy133
jfy133 Oct 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
{
"name": "nfcore",
"image": "nfcore/gitpod:latest",
"remoteUser": "gitpod",
"runArgs": ["--privileged"],
"image": "nfcore/devcontainer:latest",

// Configure tool-specific properties.
"customizations": {
// Configure properties specific to VS Code.
"vscode": {
// Set *default* container specific settings.json values on container create.
"settings": {
"python.defaultInterpreterPath": "/opt/conda/bin/python"
},
"remoteUser": "root",
"privileged": true,

// Add the IDs of extensions you want installed when the container is created.
"extensions": ["ms-python.python", "ms-python.vscode-pylance", "nf-core.nf-core-extensionpack"]
}
"remoteEnv": {
// Workspace path on the host for mounting with docker-outside-of-docker
"LOCAL_WORKSPACE_FOLDER": "${localWorkspaceFolder}"
},

"onCreateCommand": "./.devcontainer/setup.sh",

"hostRequirements": {
"cpus": 4,
"memory": "16gb",
"storage": "32gb"
}
}
13 changes: 13 additions & 0 deletions .devcontainer/setup.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#!/usr/bin/env bash

# Customise the terminal command prompt
echo "export PROMPT_DIRTRIM=2" >> $HOME/.bashrc
echo "export PS1='\[\e[3;36m\]\w ->\[\e[0m\\] '" >> $HOME/.bashrc
export PROMPT_DIRTRIM=2
export PS1='\[\e[3;36m\]\w ->\[\e[0m\\] '

# Update Nextflow
nextflow self-update

# Update welcome message
echo "Welcome to the nf-core/mag devcontainer!" > /usr/local/etc/vscode-dev-containers/first-run-notice.txt
6 changes: 4 additions & 2 deletions .github/actions/nf-test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ runs:
version: "${{ env.NXF_VERSION }}"

- name: Set up Python
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6
with:
python-version: "3.13"
python-version: "3.14"

- name: Install nf-test
uses: nf-core/setup-nf-test@v1
Expand All @@ -52,6 +52,8 @@ runs:
with:
auto-update-conda: true
conda-solver: libmamba
channels: conda-forge
channel-priority: strict
conda-remove-defaults: true

- name: Run nf-test
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/awsfulltest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,21 @@ jobs:
- name: Launch workflow via Seqera Platform
uses: seqeralabs/action-tower-launch@v2
with:
workspace_id: ${{ secrets.TOWER_WORKSPACE_ID }}
workspace_id: ${{ vars.TOWER_WORKSPACE_ID }}
access_token: ${{ secrets.TOWER_ACCESS_TOKEN }}
compute_env: ${{ secrets.TOWER_COMPUTE_ENV }}
compute_env: ${{ vars.TOWER_COMPUTE_ENV }}
revision: ${{ steps.revision.outputs.revision }}
workdir: s3://${{ secrets.AWS_S3_BUCKET }}/work/mag/work-${{ steps.revision.outputs.revision }}
workdir: s3://${{ vars.AWS_S3_BUCKET }}/work/mag/work-${{ steps.revision.outputs.revision }}
parameters: |
{
"hook_url": "${{ secrets.MEGATESTS_ALERTS_SLACK_HOOK_URL }}",
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/mag/results-${{ steps.revision.outputs.revision }}"
"outdir": "s3://${{ vars.AWS_S3_BUCKET }}/mag/results-${{ steps.revision.outputs.revision }}"
}
profiles: test_full

- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
with:
name: Seqera Platform debug log file
path: |
seqera_platform_action_*.log
seqera_platform_action_*.json
tower_action_*.log
tower_action_*.json
12 changes: 6 additions & 6 deletions .github/workflows/awstest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,20 @@ jobs:
- name: Launch workflow via Seqera Platform
uses: seqeralabs/action-tower-launch@v2
with:
workspace_id: ${{ secrets.TOWER_WORKSPACE_ID }}
workspace_id: ${{ vars.TOWER_WORKSPACE_ID }}
access_token: ${{ secrets.TOWER_ACCESS_TOKEN }}
compute_env: ${{ secrets.TOWER_COMPUTE_ENV }}
compute_env: ${{ vars.TOWER_COMPUTE_ENV }}
revision: ${{ github.sha }}
workdir: s3://${{ secrets.AWS_S3_BUCKET }}/work/mag/work-${{ github.sha }}
workdir: s3://${{ vars.AWS_S3_BUCKET }}/work/mag/work-${{ github.sha }}
parameters: |
{
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/mag/results-test-${{ github.sha }}"
"outdir": "s3://${{ vars.AWS_S3_BUCKET }}/mag/results-test-${{ github.sha }}"
}
profiles: test

- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
with:
name: Seqera Platform debug log file
path: |
seqera_platform_action_*.log
seqera_platform_action_*.json
tower_action_*.log
tower_action_*.json
2 changes: 1 addition & 1 deletion .github/workflows/clean-up.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
issues: write
pull-requests: write
steps:
- uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9
- uses: actions/stale@5f858e3efba33a5ca4407a664cc011ad407f2008 # v10
with:
stale-issue-message: "This issue has been tagged as awaiting-changes or awaiting-feedback by an nf-core contributor. Remove stale label or add a comment otherwise this issue will be closed in 20 days."
stale-pr-message: "This PR has been tagged as awaiting-changes or awaiting-feedback by an nf-core contributor. Remove stale label or add a comment if it is still useful."
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/download_pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ jobs:
- name: Disk space cleanup
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1

- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
- uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6
with:
python-version: "3.13"
python-version: "3.14"
architecture: "x64"

- name: Setup Apptainer
Expand All @@ -57,7 +57,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install git+https://github.com/nf-core/tools.git@dev
pip install git+https://github.com/nf-core/tools.git

- name: Make a cache directory for the container images
run: |
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/fix_linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ jobs:
runs-on: ubuntu-latest
steps:
# Use the @nf-core-bot token to check out so we can push later
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
with:
token: ${{ secrets.nf_core_bot_auth_token }}

# indication that the linting is being fixed
- name: React on comment
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5
with:
comment-id: ${{ github.event.comment.id }}
reactions: eyes
Expand All @@ -32,9 +32,9 @@ jobs:
GITHUB_TOKEN: ${{ secrets.nf_core_bot_auth_token }}

# Install and run pre-commit
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
- uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6
with:
python-version: "3.13"
python-version: "3.14"

- name: Install pre-commit
run: pip install pre-commit
Expand All @@ -47,7 +47,7 @@ jobs:
# indication that the linting has finished
- name: react if linting finished succesfully
if: steps.pre-commit.outcome == 'success'
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5
with:
comment-id: ${{ github.event.comment.id }}
reactions: "+1"
Expand All @@ -67,21 +67,21 @@ jobs:
- name: react if linting errors were fixed
id: react-if-fixed
if: steps.commit-and-push.outcome == 'success'
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5
with:
comment-id: ${{ github.event.comment.id }}
reactions: hooray

- name: react if linting errors were not fixed
if: steps.commit-and-push.outcome == 'failure'
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5
with:
comment-id: ${{ github.event.comment.id }}
reactions: confused

- name: react if linting errors were not fixed
if: steps.commit-and-push.outcome == 'failure'
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5
with:
issue-number: ${{ github.event.issue.number }}
body: |
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ jobs:
pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5

- name: Set up Python 3.13
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
- name: Set up Python 3.14
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6
with:
python-version: "3.13"
python-version: "3.14"

- name: Install pre-commit
run: pip install pre-commit
Expand All @@ -28,14 +28,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out pipeline code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5

- name: Install Nextflow
uses: nf-core/setup-nextflow@v2

- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5
- uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6
with:
python-version: "3.13"
python-version: "3.14"
architecture: "x64"

- name: read .nf-core.yml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linting_comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
run: echo "pr_number=$(cat linting-logs/PR_number.txt)" >> $GITHUB_OUTPUT

- name: Post PR comment
uses: marocchino/sticky-pull-request-comment@52423e01640425a022ef5fd42c6fb5f633a02728 # v2
uses: marocchino/sticky-pull-request-comment@773744901bac0e8cbb5a0dc842800d45e9b2b405 # v2
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
number: ${{ steps.pr_number.outputs.pr_number }}
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/nf-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ concurrency:

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NFT_VER: "0.9.2"
NFT_VER: "0.9.3"
NFT_WORKDIR: "~"
NXF_ANSI_LOG: false
NXF_SINGULARITY_CACHEDIR: ${{ github.workspace }}/.singularity
Expand All @@ -40,7 +40,7 @@ jobs:
rm -rf ./* || true
rm -rf ./.??* || true
ls -la ./
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
with:
fetch-depth: 0

Expand Down Expand Up @@ -86,7 +86,7 @@ jobs:
TOTAL_SHARDS: ${{ needs.nf-test-changes.outputs.total_shards }}

steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
with:
fetch-depth: 0

Expand All @@ -96,6 +96,7 @@ jobs:
continue-on-error: ${{ matrix.NXF_VER == 'latest-everything' }}
env:
NFT_WORKDIR: ${{ env.NFT_WORKDIR }}
NXF_VERSION: ${{ matrix.NXF_VER }}
with:
profile: ${{ matrix.profile }}
shard: ${{ matrix.shard }}
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/release-announcements.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ jobs:
run: |
echo "topics=$(curl -s https://nf-co.re/pipelines.json | jq -r '.remote_workflows[] | select(.full_name == "${{ github.repository }}") | .topics[]' | awk '{print "#"$0}' | tr '\n' ' ')" | sed 's/-//g' >> $GITHUB_OUTPUT

- name: get description
id: get_description
run: |
echo "description=$(curl -s https://nf-co.re/pipelines.json | jq -r '.remote_workflows[] | select(.full_name == "${{ github.repository }}") | .description' >> $GITHUB_OUTPUT

- uses: rzr/fediverse-action@master
with:
access-token: ${{ secrets.MASTODON_ACCESS_TOKEN }}
Expand All @@ -23,6 +28,8 @@ jobs:
message: |
Pipeline release! ${{ github.repository }} v${{ github.event.release.tag_name }} - ${{ github.event.release.name }}!

${{ steps.get_topics.outputs.description }}

Please see the changelog: ${{ github.event.release.html_url }}

${{ steps.get_topics.outputs.topics }} #nfcore #openscience #nextflow #bioinformatics
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template-version-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out pipeline code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
with:
ref: ${{ github.event.pull_request.head.sha }}

Expand Down
10 changes: 0 additions & 10 deletions .gitpod.yml

This file was deleted.

7 changes: 3 additions & 4 deletions .nf-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,14 @@ lint:
- config_defaults:
- params.phix_reference
- params.lambda_reference
nf_core_version: 3.3.2
nf_core_version: 3.4.1
repository_type: pipeline
template:
author: "Hadrien Gourlé, Daniel Straub, Sabrina Krakau, James A. Fellows Yates,
Maxime Borry"
author: "Hadrien Gourlé, Daniel Straub, Sabrina Krakau, James A. Fellows Yates, Maxime Borry"
description: Assembly, binning and annotation of metagenomes
force: false
is_nfcore: true
name: mag
org: nf-core
outdir: .
version: 5.0.0
version: 5.1.0
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ repos:
additional_dependencies:
- prettier@3.6.2
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v5.0.0
rev: v6.0.0
hooks:
- id: trailing-whitespace
args: [--markdown-linebreak-ext=md]
Expand Down
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ testing/
testing*
*.pyc
bin/
.nf-test/
ro-crate-metadata.json
Loading
Loading