Skip to content

Add support for mTLS - #102

Open
or-ram wants to merge 2 commits into
nginx:mainfrom
or-ram:or-new-task
Open

Add support for mTLS#102
or-ram wants to merge 2 commits into
nginx:mainfrom
or-ram:or-new-task

Conversation

@or-ram

@or-ram or-ram commented Sep 18, 2025

Copy link
Copy Markdown

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using fix keyword here in this description and in corresponding commit message.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes

@or-ram or-ram closed this Sep 18, 2025
@or-ram or-ram reopened this Jun 5, 2026
@azlato

azlato commented Jul 21, 2026

Copy link
Copy Markdown

This PR adds mTLS support for OTLP export.

Why it matters:

  • It lets nginx-otel authenticate to collectors that require client certs.
  • It adds the missing pieces: client key, client cert chain, and test coverage.

I need this change too, and I think it would be very useful to get more eyes on this PR.

For reviewers, the main things to check are:

  • config directives: client_private_key and client_certificate_chain
  • how cert/key are loaded and passed into gRPC SSL credentials
  • whether the new mTLS test covers the intended collector auth flow

This looks small, focused, and practical. Please take a look when you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants