Add go fix ./... to Makefile and CI

[Copilot]

Adds go fix ./... as an early CI gate to prevent outdated Go idioms from accumulating, similar to the existing go mod tidy check.

Changes

• tools/make/lint.mk: New go-fix target alongside fmt and vet
• .github/workflows/ci.yaml:
  • New go-fix job — runs make go-fix, fails if any files are modified (i.e., go fix would have made changes)
  • build-images, build-and-test, e2e, e2e-multi-namespace, and e2e-uninstall all depend on go-fix, ensuring expensive jobs are gated behind it

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Add go fix ./... to our Makefile and CI</issue_title>
<issue_description>Go 1.26 has revamped go fix ./... to perform automatic fixes. I'd like to include it in our CI github workflow similar to how we do a go mod tidy check to make sure that we don't pile up outdated idioms. Make sure it runs early on in our CI steps and that the more expensive tests like build and testing depend on it.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Add go fix ./... to our Makefile and CI #790

---

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

[Copilot]

Pull request overview

Adds a go fix ./... check to the project’s Makefile and wires it into GitHub Actions CI so that outdated Go idioms are caught (and required to be committed) before running more expensive jobs.

Changes:

• Adds a make go-fix target that runs go fix ./....
• Adds a go-fix CI job that runs the target and fails if it modifies the working tree.
• Updates CI job dependency graph so expensive jobs wait on the new early gate(s).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
tools/make/lint.mk	Adds a go-fix make target to run go fix ./....
.github/workflows/ci.yaml	Introduces a go-fix job and updates job needs/if gating to run it early.

Comments suppressed due to low confidence (1)

.github/workflows/ci.yaml:145

• build-and-test can run when actions/charts/chartyaml/tests change, but it now has unconditional needs: go-mod-tidy and needs: go-fix. Since those jobs are currently gated to only run on go changes, build-and-test will be skipped for non-go changes due to unmet needs. Fix by aligning the if conditions (or removing these from needs where they aren’t required).

  build-and-test:
    runs-on: ubuntu-latest
    needs:
    - changes
    - kubebuilder-diff
    - lint
    - go-mod-tidy
    - go-fix
    if: |
      (github.event_name == 'push' && github.ref_name == 'main')
      ||
      (
        (needs.changes.outputs.actions == 'true') ||
        (needs.changes.outputs.go == 'true') ||
        (needs.changes.outputs.charts == 'true') ||
        (needs.changes.outputs.chartyaml == 'true') ||
        (needs.changes.outputs.tests == 'true') ||
        (needs.changes.outputs.make == 'true')

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.41%. Comparing base (6838feb) to head (cfddf52).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
- Coverage   51.64%   51.41%   -0.24%     
==========================================
  Files         101      101              
  Lines       11188    11188              
==========================================
- Hits         5778     5752      -26     
- Misses       4993     5014      +21     
- Partials      417      422       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.