Skip to content

feat(signals): add RxMethod and SignalMethod types to public API#4744

Merged
timdeschryver merged 2 commits intomainfrom
feat/signals/rxmethod-signalmethod-types
Mar 30, 2025
Merged

feat(signals): add RxMethod and SignalMethod types to public API#4744
timdeschryver merged 2 commits intomainfrom
feat/signals/rxmethod-signalmethod-types

Conversation

@markostanimirovic
Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

RxMethod/SignalMethod` types can be used when specifying the input type of the custom SignalStore feature:

export function withBar() {
  return signalStoreFeature(
    { methods: type<{ foo: RxMethod<number> }>() },
    withMethods(({ foo }) => ({
      bar: () => foo(10),
    })),
  );
}

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 29, 2025

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 801a852
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67e94d5f82d01300087f9482
😎 Deploy Preview https://deploy-preview-4744--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Contributor

@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timdeschryver timdeschryver merged commit 40e78d9 into main Mar 30, 2025
10 checks passed
@timdeschryver timdeschryver deleted the feat/signals/rxmethod-signalmethod-types branch March 30, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants