Skip to content

docs(testing): expose how to define the type of an signal store insta…#4745

Closed
distante wants to merge 1 commit intongrx:mainfrom
distante:main
Closed

docs(testing): expose how to define the type of an signal store insta…#4745
distante wants to merge 1 commit intongrx:mainfrom
distante:main

Conversation

@distante
Copy link
Copy Markdown

…nce.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There is no information of how to get the correct type of a Signal Store instance for testing.

What is the new behavior?

Information was added.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 29, 2025

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4043398
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67e832956be53d00084a99ce
😎 Deploy Preview https://deploy-preview-4745--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markostanimirovic
Copy link
Copy Markdown
Member

This is already mentioned on the "FAQ" page (How can I get the type of a SignalStore): https://ngrx.io/guide/signals/faq

@rainerhahnekamp
Copy link
Copy Markdown
Contributor

@markostanimirovic. Yes but we should at least refer to it in the testing section. this PR came out of a discussion Reddit.

@markostanimirovic
Copy link
Copy Markdown
Member

Closing this PR because info on how to define the SignalStore instance type is already available on the FAQ page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants