feat(eslint-plugin): add schematic support for flat configs#4747
Merged
brandonroberts merged 3 commits intomainfrom Apr 21, 2025
Merged
feat(eslint-plugin): add schematic support for flat configs#4747brandonroberts merged 3 commits intomainfrom
brandonroberts merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for ngrx-io canceled.
|
13 tasks
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
modules/eslint-plugin/schematics/ng-add/index.ts:96
- If no import declarations exist, the insertion point defaults to 0, which may insert the new import statement in an unexpected location; consider handling this case separately to ensure the import is placed in a logical location relative to the tseslint.config call.
recorder.insertRight(lastImport?.end ?? 0, `\nimport ngrx from '${ngrxPlugin}';`);
markostanimirovic
approved these changes
Apr 6, 2025
rainerhahnekamp
approved these changes
Apr 16, 2025
Contributor
rainerhahnekamp
left a comment
There was a problem hiding this comment.
Ouch - migrating to flat config isn’t as straightforward as it looks.
We went through something similar in Sheriff, and it definitely took some effort.
Fingers crossed the flat config stays stable for a few years now! 🤞
brandonroberts
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current schematic only supports the "old" ESLint configuration, which exists in a JSON file.
Closes #4643
What is the new behavior?
This PR adds support to add the NgRx plugin to the flat config (Eslint v9.
It supports the following formats:
Does this PR introduce a breaking change?
Other information