Skip to content

test(eslint-plugin): migrate from Jest to Vitest#4757

Merged
markostanimirovic merged 1 commit intomainfrom
test/eslint-plugin-vitest
Apr 15, 2025
Merged

test(eslint-plugin): migrate from Jest to Vitest#4757
markostanimirovic merged 1 commit intomainfrom
test/eslint-plugin-vitest

Conversation

@timdeschryver
Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe:

What is the current behavior?

Unit tests for eslint-plugin are run with Jest.

Closes #

What is the new behavior?

Unit tests for eslint-plugin are run with Vitest.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2025

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 6d02ee6
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67fea5383a395d0008603f16

Copy link
Copy Markdown
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

Copy link
Copy Markdown
Contributor

@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff.

Not part of this PR, but the question for me is, if we want to keep the global definitions or if we also want to do explicit imports with describe, it, expect, etc. Explicit imports would improve support in IDEs (although it might not be necessary, when vite.config.ts is present).

@markostanimirovic markostanimirovic merged commit 4357733 into main Apr 15, 2025
10 checks passed
@markostanimirovic markostanimirovic deleted the test/eslint-plugin-vitest branch April 15, 2025 22:41
@brandonroberts
Copy link
Copy Markdown
Member

The explicit imports can be used when testing without zone.js, but the global definitions are required when zone.js is used due to the patching of the describe, it, expect, etc functions.

@rainerhahnekamp
Copy link
Copy Markdown
Contributor

@brandonroberts, ah good to know. Thanks for the info Brandon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants