test(eslint-plugin): migrate from Jest to Vitest#4757
Merged
markostanimirovic merged 1 commit intomainfrom Apr 15, 2025
Merged
Conversation
✅ Deploy Preview for ngrx-io canceled.
|
rainerhahnekamp
approved these changes
Apr 15, 2025
Contributor
rainerhahnekamp
left a comment
There was a problem hiding this comment.
Cool stuff.
Not part of this PR, but the question for me is, if we want to keep the global definitions or if we also want to do explicit imports with describe, it, expect, etc. Explicit imports would improve support in IDEs (although it might not be necessary, when vite.config.ts is present).
markostanimirovic
approved these changes
Apr 15, 2025
Member
|
The explicit imports can be used when testing without |
Contributor
|
@brandonroberts, ah good to know. Thanks for the info Brandon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Unit tests for eslint-plugin are run with Jest.
Closes #
What is the new behavior?
Unit tests for eslint-plugin are run with Vitest.
Does this PR introduce a breaking change?
Other information