5.1.0 release by fredericDelaporte · Pull Request #1525 · nhibernate/nhibernate-core

fredericDelaporte · 2018-01-11T11:33:00Z

In order to avoid forgetting breaking changes, here is a start of release notes.

Ingres9Dialect as of NH-3921 - Sequence support for Ingres9 #529.
Dialect obsoleted overridable methods as of NH-1285 - Drop/Create script with default_schema/default_catalog fix(SqlServer) #448. (I have not found any other case, by looking at all Obsolete attributes.)
Linq inequality as of Linq provider generates different SQL query (with not equal) in version 4 and 5 #1495 (v5.0 change).

fredericDelaporte

I have already updated the release notes and prepared the GitHub release draft.

fredericDelaporte · 2018-03-11T13:34:55Z

ReleaseProcedure.txt


-
  * In GitHub, make sure no open issues have milestone set to the release
-    that is about to happen (as these will show in the release notes).


as these will show in the release notes

No more true with GitReleaseManager. It only takers into account closed PR/issues.

fredericDelaporte · 2018-03-11T13:35:50Z

ReleaseProcedure.txt

+
+  * Create a draft release in Github with GitReleaseManager. If you have used
+    the NHibernate build menu, it should be available in Tools\gitreleasemanage.x.x.x\
+    (change x.x.x by its current version in tools).


Its chocolatey version is obsolete and unable to work with current GitHub.

bahusoid · 2018-03-11T16:49:06Z

releasenotes.txt

+   * #1403 Add timeouts support to MultiCriteria
+   * #1377 Logging refactoring
+   * #954 NH-3807 - Support for .NET Core 2.0
+   * #948 NH-3435 - Ability to select the root entity in a criteria projection


I think this issue needs to be renamed to "Ability to select entities in a criteria projection" . As implementation #1471 is not limited to root entity.

hazzik · 2018-03-11T21:22:07Z

releasenotes.txt

+
+** Highlights
+    * NHibernate has gained two new target frameworks: .Net Core 2.0 and .Net Standard 2.0. NHibernate NuGet package
+      provides them, along with the .Net framework 4.6.1 build.


Need to mention limitations:

Binary serialization is not supported - the user shall implement serialization surrogates for System.Type, FieldInfo, PropertyInfo, MethodInfo, ConstructorInfo, Delegate, etc.

other limitations mentioned in the PR.

hazzik · 2018-03-12T00:39:11Z

ReleaseProcedure.txt

+    If no error or other issue requiring further changes occurred, merge
+    the release PR and wait for the resulting commit CI release build.
+
+  * Retrieves the artifacts of the CI release build.


Its chocolatey version is obsolete and unable to access current GitHub. Only its NuGet version is currently usable. (Its MyGet feed seems gone.)

fredericDelaporte · 2018-03-16T12:17:40Z

So well, what about #626 "Split database providers into own projects"? I have reviewed it one more time and approved it ~~only two minor adjustments are to be done in my opinion~~ (now done). And I still think it would be valuable to have it in 5.1.

This aside, what should be the "immediate" plan:

Release this in its current state (or NH-4008 - Split database providers into own projects. #626 included but nothing else)?
And right after that:
- Observe a 5.0 similar "cooldown" period, just merging regressions, simple bugs or minor improvements, till releasing a 5.1.1?
- Merge things for a 5.2?
- Go straight to merging things for a 6.0, especially removing the accumulated obsoletes and handling 6.0 TODOs?

hazzik · 2018-03-16T21:01:10Z

Release this in its current state
Observe a 5.0 similar "cooldown" period, just merging regressions, simple bugs or minor improvements, till releasing a 5.1.1
Merge things for a 5.2 and call it 6.0 if enough new features are emerged

ngbrown · 2018-03-16T22:10:36Z

Observe a 5.0 similar "cooldown" period, just merging regressions, simple bugs or minor improvements, till releasing a 5.1.1

Regressions and bugs ideally would be on a 5.1.x branch so 5.2 changes can immediately be merged to trunk.

fredericDelaporte added p: Minor c: Documentation t: Task labels Jan 11, 2018

fredericDelaporte added this to the 5.1 milestone Jan 11, 2018

fredericDelaporte force-pushed the 5.1.0 branch 2 times, most recently from cadf8cf to b7ff693 Compare January 21, 2018 12:49

fredericDelaporte force-pushed the 5.1.0 branch from b7ff693 to 82e4468 Compare February 28, 2018 11:59

fredericDelaporte force-pushed the 5.1.0 branch 2 times, most recently from ed55537 to 4340576 Compare March 11, 2018 13:38

fredericDelaporte commented Mar 11, 2018

View reviewed changes

fredericDelaporte changed the title ~~[WIP] Preparing 5.1.0 release~~ [WIP] 5.1.0 release Mar 11, 2018

fredericDelaporte force-pushed the 5.1.0 branch from 4340576 to 12fe97d Compare March 11, 2018 13:42

bahusoid reviewed Mar 11, 2018

View reviewed changes

fredericDelaporte force-pushed the 5.1.0 branch from 12fe97d to c0b9b8a Compare March 11, 2018 19:38

hazzik reviewed Mar 11, 2018

View reviewed changes

hazzik reviewed Mar 12, 2018

View reviewed changes

fredericDelaporte force-pushed the 5.1.0 branch 4 times, most recently from 10b5b5c to 922f76f Compare March 12, 2018 23:20

hazzik previously approved these changes Mar 12, 2018

View reviewed changes

fredericDelaporte dismissed hazzik’s stale review via 00c72eb March 14, 2018 01:05

fredericDelaporte force-pushed the 5.1.0 branch 2 times, most recently from 00c72eb to b44c03a Compare March 14, 2018 10:18

fredericDelaporte added 6 commits March 14, 2018 15:59

Document breaking changes due to Ingres9 sequence support.

2b7b5d5

Documenting a forgotten breaking change.

96975c6

Bump version to 5.1

4cb5f11

Add nhibernate#448 possible breaking change.

89e39da

Add highlight in release note: .Net Core & Standard.

6569936

Include GitReleaseManager in Nhibernate tooling.

ec3c248

Its chocolatey version is obsolete and unable to access current GitHub. Only its NuGet version is currently usable. (Its MyGet feed seems gone.)

fredericDelaporte added 2 commits March 14, 2018 15:59

Update release procedure.

fb734b2

Update release notes for 5.1.0

8fe355c

fredericDelaporte force-pushed the 5.1.0 branch from b44c03a to 8fe355c Compare March 14, 2018 15:00

fredericDelaporte changed the title ~~[WIP] 5.1.0 release~~ 5.1.0 release Mar 15, 2018

hazzik approved these changes Mar 16, 2018

View reviewed changes

fredericDelaporte merged commit 2f703d0 into nhibernate:master Mar 17, 2018

fredericDelaporte deleted the 5.1.0 branch March 17, 2018 08:22

fredericDelaporte added the r: Fixed label Mar 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

5.1.0 release#1525

5.1.0 release#1525
fredericDelaporte merged 8 commits intonhibernate:masterfrom
fredericDelaporte:5.1.0

fredericDelaporte commented Jan 11, 2018 •

edited

Loading

Uh oh!

fredericDelaporte left a comment

Uh oh!

fredericDelaporte Mar 11, 2018

Uh oh!

fredericDelaporte Mar 11, 2018

Uh oh!

bahusoid Mar 11, 2018

Uh oh!

fredericDelaporte Mar 11, 2018

Uh oh!

hazzik Mar 11, 2018 •

edited

Loading

Uh oh!

hazzik Mar 12, 2018

Uh oh!

fredericDelaporte commented Mar 16, 2018 •

edited

Loading

Uh oh!

hazzik commented Mar 16, 2018

Uh oh!

ngbrown commented Mar 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants



		* In GitHub, make sure no open issues have milestone set to the release
		that is about to happen (as these will show in the release notes).

Conversation

fredericDelaporte commented Jan 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fredericDelaporte left a comment

Choose a reason for hiding this comment

Uh oh!

fredericDelaporte Mar 11, 2018

Choose a reason for hiding this comment

Uh oh!

fredericDelaporte Mar 11, 2018

Choose a reason for hiding this comment

Uh oh!

bahusoid Mar 11, 2018

Choose a reason for hiding this comment

Uh oh!

fredericDelaporte Mar 11, 2018

Choose a reason for hiding this comment

Uh oh!

hazzik Mar 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hazzik Mar 12, 2018

Choose a reason for hiding this comment

Uh oh!

fredericDelaporte commented Mar 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hazzik commented Mar 16, 2018

Uh oh!

ngbrown commented Mar 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fredericDelaporte commented Jan 11, 2018 •

edited

Loading

hazzik Mar 11, 2018 •

edited

Loading

fredericDelaporte commented Mar 16, 2018 •

edited

Loading