Map Firebird UDF functions to built-in functions - #3836
Draft
hazzik wants to merge 2 commits into
Draft
Conversation
hazzik
changed the title
hazzik
changed the title
hazzik
marked this pull request as draft
August 28, 2026 20:14
| RegisterFunction("rand", new NoArgSQLFunction("rand", NHibernateUtil.Double)); | ||
| RegisterFunction("random", new NoArgSQLFunction("rand", NHibernateUtil.Double)); | ||
| RegisterFunction("sign", new StandardSQLFunction("sign", NHibernateUtil.Int32)); | ||
| RegisterFunction("sqtr", new StandardSQLFunction("sqtr", NHibernateUtil.Double)); |
Member
There was a problem hiding this comment.
Wasn't this not working at all, since the spelling error was in the native name, too?
In such case, why keep the spelling error in HQL, if it was not functional? I mean, register sqrt in HQL if it is not already in the base dialect, and remove sqtr if it was not working at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map the HQL function names that come from the
ib_udfandfbudfexternal libraries to the equivalent Firebird built-in functions. Thesqtrname was a spelling error and now callssqrt.These libraries are not installed by default, and Firebird 4 does not permit external functions. The names could not work on a standard installation.