Skip to content

[26.0] Add CreateAICalculatedPowerChan API metadata#1214

Merged
HSKhor-NI merged 3 commits into
ni:mainfrom
HSKhor-NI:users/khsheng/daqmx/add_calculated_power_api_metadata
Nov 7, 2025
Merged

[26.0] Add CreateAICalculatedPowerChan API metadata#1214
HSKhor-NI merged 3 commits into
ni:mainfrom
HSKhor-NI:users/khsheng/daqmx/add_calculated_power_api_metadata

Conversation

@HSKhor-NI

Copy link
Copy Markdown
Contributor

What does this Pull Request accomplish?

Pull in new metadata file generated in grpc-device-scrapigen that contain metadata for DAQmxCreateCalculatedPower API.

Why should this Pull Request be merged?

To support DAQmxCreateCalculatedPower call through grpc interpreter in python API

What testing has been done?

  • Able to generate nidaqmx.proto that contain DAQmxCreateCalculatedPower API
  • Able to be consumed by nidamx-python to generate grpc_interpretr with updated API.

@HSKhor-NI HSKhor-NI marked this pull request as ready for review October 29, 2025 08:15
Comment thread source/codegen/metadata/nidaqmx/functions.py
@HSKhor-NI HSKhor-NI merged commit ca88a95 into ni:main Nov 7, 2025
9 checks passed
Comment on lines +3449 to +3450
THERMOCOUPLE_TYPE1_A_TYPE_TC = 16208;
THERMOCOUPLE_TYPE1_C_TYPE_TC = 16209;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thermocouple type additions are unrelated to the goal of this PR which is to add the CreateAICalculatedPowerChannel API. @maxxboehme , @astarche , is there an expected way to to limit the API additions to a specific feature or is the expected process to update the whole DAQmx API at once?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HSKhor-NI , if the other additions for the DAQmx API beyond Calculated Power Channel remain in this PR, I think the title should be changed to reflect that. Perhaps "Update DAQmx API metadata to 26.0 to pull in the Calculated Power Channel API"

@bkeryan bkeryan Nov 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the PR was previously suggested for nidaqmx-python: ni/nidaqmx-python#876

Comment thread imports/include/NIDAQmx.h
Comment on lines +740 to +744
#define DAQmx_Dev_IDPin_PinNames 0x31F1 // Indicates the names of all the ID Pins on this device.
#define DAQmx_Dev_IDPin_PinStatuses 0x31F2 // Indicates status of each ID Pin.
#define DAQmx_Dev_IDPin_MemFamilyCodes 0x31F3 // Indicates the family code of the memory connected to each ID Pin. Each array element corresponds to an ID Pin. The array contains 0 for each ID Pin with no memory connected.
#define DAQmx_Dev_IDPin_MemSerialNums 0x31F4 // Indicates the serial number of the memory connected to each ID Pin. Each array element corresponds to an ID Pin. The array contains an empty string for each ID Pin with no memory connected.
#define DAQmx_Dev_IDPin_MemSizes 0x31F5 // Indicates the size in bytes of the memory connected to each ID Pin. Each array element corresponds to an ID Pin. The array contains 0 for each ID Pin with no memory connected.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The update to the comments here are unrelated to the Calculated Power Channel API additions.

Comment thread imports/include/NIDAQmx.h
Comment on lines +2499 to +2500
#define DAQmx_Val_A_Type_TC 16208 // A
#define DAQmx_Val_C_Type_TC 16209 // C

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The addition of these thermocouple type enums are unrelated to the Calculated Power Channel API additions that led to this PR.

Comment thread imports/include/NIDAQmx.h
int32 __CFUNC DAQmxAdjust4305Cal (CalHandle calHandle, float64 refVoltage);
int32 __CFUNC DAQmxAdjust4309Cal (CalHandle calHandle, float64 refVoltage);
int32 __CFUNC DAQmxAdjust4310Cal (CalHandle calHandle, float64 refVoltage);
int32 __CFUNC DAQmxAdjust4311Cal (CalHandle calHandle, float64 rangeMax, float64 rangeMin, float64 refVoltage);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the DAQmxAdjust4311Cal function is independent from the addition of the Calculated Power Channel API but was present in the 2025 Q4 DAQmx C API.

Comment thread imports/include/NIDAQmx.h
Comment on lines +3601 to +3602
int32 __CFUNC DAQmxGet9320CalAdjustPoints(CalHandle calHandle, float64* adjustmentPoints, uInt32 bufferSize);
int32 __CFUNC DAQmxAdjust9320Cal(CalHandle calHandle, const char channelNames[], float64 value);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cal function additions are unrelated to the Calculated Power Channel API additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants