Remove NI-DMM Private Header Files#1219
Merged
Merged
Conversation
aravind-70
requested review from
astarche,
maxxboehme and
reckenro
as code owners
reckenro
approved these changes
Oct 31, 2025
Avinash2Suresh
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This pull request removes the
nidmmPrivate.handnidmmRemoteDebug.hthat were used in nidmm. The functionality is still achieved through public header files. For reference: refactor: Update addition.hapigen to remove private headersWhy should this Pull Request be merged?
This change is to ensure that we don't expose proprietary private entry points on NI gRPC Device Server.
What testing has been done?
Manual testing. The build was successfully completed on Windows. We are relying on the pipeline to validate the build on Linux.