Skip to content

RFmx 2026 Q1 API code generation#1228

Merged
RahulBenaka merged 5 commits into
mainfrom
users/rnagaraj/rfmx_grpc_apis
Dec 12, 2025
Merged

RFmx 2026 Q1 API code generation#1228
RahulBenaka merged 5 commits into
mainfrom
users/rnagaraj/rfmx_grpc_apis

Conversation

@RahulBenaka

@RahulBenaka RahulBenaka commented Dec 6, 2025

Copy link
Copy Markdown
Contributor

What does this Pull Request accomplish?

Updates niRFmxBluetooth in grpc-device-scrapigen to 26.0.0
Updates niRFmxNR in grpc-device-scrapigen to 26.0.0
Updates niRFmxWlan in grpc-device-scrapigen to 26.0.0
Updates the gRPC Scrapigen Device Code for Bluetooth ModAcc attributes and enums
Updates the gRPC Scrapigen Device Code for NR OBW attribute and enum
Updates the gRPC Scrapigen Device Code for WLAN Ofdm attributes, enums and APIs and OfdmModAcc attributes and enums.

Why should this Pull Request be merged?

Updated to match the upcoming release of niRFmxBluetooth to 26.0.0
Updated to match the upcoming release of niRFmxNR 26.0.0
Updated to match the upcoming release of niRFmxWlan 26.0.0

What testing has been done?

Manually inspected generated files.
Copied files from grpc-device-scrapigen/out/rfmxbluetooth/export/ to grpc-device/source/codegen/metadata/nirfmxbluetooth/ and built grpc-device successfully.
Manually inspected nirfmxbluetooth.proto file.
Copied files from grpc-device-scrapigen/out/rfmxnr/export/ to grpc-device/source/codegen/metadata/nirfmxnr/ and built grpc-device successfully.
Manually inspected nirfmxnr.proto file.
Copied files from grpc-device-scrapigen/out/rfmxwlan/export/ to grpc-device/source/codegen/metadata/nirfmxwlan/ and built grpc-device successfully.
Manually inspected nirfmxwlan.proto file.

generated client code that uses the old name will have to be updated when pulling in the new proto. Binary compatibility will be maintained.

@RahulBenaka

RahulBenaka commented Dec 6, 2025

Copy link
Copy Markdown
Contributor Author

@reckenro @astarche "Validate Python" job in the PR is failing.
image
I did try to use co-pilot and resolve the error, but I was only able to understand the error. Where should I update the protobuf version so that I can re-run the cmake commands and resolve this issue?

Comment thread generated/nirfmxbluetooth/nirfmxbluetooth.proto
@RahulBenaka

Copy link
Copy Markdown
Contributor Author

@reckenro @astarche "Validate Python" job in the PR is failing. image I did try to use co-pilot and resolve the error, but I was only able to understand the error. Where should I update the protobuf version so that I can re-run the cmake commands and resolve this issue?

I have resolved the issue. Can you please review?
@reckenro @astarche

Comment thread examples/pyproject.toml Outdated
Comment thread examples/pyproject.toml
@bkeryan

bkeryan commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

@reckenro @astarche "Validate Python" job in the PR is failing. image I did try to use co-pilot and resolve the error, but I was only able to understand the error. Where should I update the protobuf version so that I can re-run the cmake commands and resolve this issue?

Python stubs generated with protobuf v6 and/or newer versions of grpcio-tools import google.protobuf.runtime_version in order to do some version checks. This submodule did not exist in older protobuf versions, so you get an ImportError before it even gets to the version check.

grpcio-tools 1.49.1 requires protobuf>=4.21.3,<5.0dev, so it cannot coexist with protobuf v5 or v6. However, the generated code from grpcio-tools 1.49.1 works fine with protobuf v5 and v6.

@bkeryan bkeryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python examples project looks ok to me.

Comment thread examples/pyproject.toml
@astarche astarche added the source-breaking Change to proto file that will break client if they update label Dec 10, 2025
@RahulBenaka

Copy link
Copy Markdown
Contributor Author

Python examples project looks ok to me.

But the Validate Python Job in PR is still failing.
I did run poetry update too, but it didn't bring in any new changes. The Job is getting cancelled (not errored out). And it is also not letting run the other build_desktop jobs too. Any idea why this job could be cancelleing out?

@bkeryan @reckenro

@RahulBenaka

Copy link
Copy Markdown
Contributor Author

Python examples project looks ok to me.

But the Validate Python Job in PR is still failing. I did run poetry update too, but it didn't bring in any new changes. The Job is getting cancelled (not errored out). And it is also not letting run the other build_desktop jobs too. Any idea why this job could be cancelleing out?

@bkeryan @reckenro

Its resoved now

@RahulBenaka RahulBenaka merged commit 200a6d5 into main Dec 12, 2025
17 of 18 checks passed
@RahulBenaka RahulBenaka deleted the users/rnagaraj/rfmx_grpc_apis branch December 12, 2025 01:59
@bkeryan

bkeryan commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Python examples project looks ok to me.

But the Validate Python Job in PR is still failing. I did run poetry update too, but it didn't bring in any new changes. The Job is getting cancelled (not errored out). And it is also not letting run the other build_desktop jobs too. Any idea why this job could be cancelleing out?
@bkeryan @reckenro

Its resoved now

Ok, I filed a bug about the underlying problem with the build workflows: #1230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source-breaking Change to proto file that will break client if they update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants