RFmx 2026 Q3 Bug Fixes#1267
Conversation
RahulBenaka
requested review from
astarche,
maxxboehme and
reckenro
as code owners
…ng extra param from VNA API
…lementSetPortConnectors in rfmxvna
…les and README.md file
…nagaraj/rfmx_bug_fix
RahulBenaka
added
binary-breaking
| nidevice_grpc.Session instrument = 1; | ||
| string selector_string = 2; | ||
| int32 array_size = 3; | ||
| int32 timeout = 3; |
There was a problem hiding this comment.
Thanks for tagging the PR breaking.
Can you also briefly call out in a new section in the PR description each of these breaking changes and for which API they're for?
That makes it easier when we make a release to comb through and see at a high level what breaking changes are associated with the breaking PRs so we can include that info in the release notes.
|
|
||
| //--------------------------------------------------------------------- | ||
| // This file is generated from NI-RFMXINSTR API metadata version 25.3.0 | ||
| // This file is generated from NI-RFMXINSTR API metadata version 26.5.0 |
There was a problem hiding this comment.
This comment is just to block the PR . Similar reasoning as the comment in the other PR
grpc-device will be having an early 2.18 release for some critical changes before releasing again for 2.19. This process will be starting tomorrow 6/16 and would want this change to go in after that early release has happened which should be done before the end of the week June 19th.
4 participants
What does this Pull Request accomplish?
Updates niRFmxInstr metadata and generated gRPC code to 26.5.0.
Updates niRFmxPulse metadata and generated gRPC code to 26.5.0.
Updates niRFmxVNA metadata and generated gRPC code to 26.5.0.
Updates niRFmxWLAN metadata and generated gRPC code to 26.5.0.
Updates README driver support entries for RFmx Pulse, RFmx VNA, and RFmx WLAN.
Fixes the WLAN
CfgDigitalEdgeTriggerRequestparameter naming inconsistency by correctingdigital_edge_source_rawto match the expecteddigital_edge_sourcenaming.Adds the missing RFmxInstr Split APIs, including
CfgSParameterExternalAttenuationTableSplitandFetchRawIQDataSplit.Adds the missing WLAN
OFDMModAccFetchReferenceDataConstellationTraceAPIs, including interleaved IQ and split variants.Corrects the RFmxVNA
CalkitManagerCalkitCalibrationElementSetPortConnectorsgenerated API signature.Corrects the RFmxPulse
FetchAcquiredAmplitudeTracegenerated API parameter naming/signature.Regenerates affected proto, client, service, library, mock library, and compilation test files.
Work items addressed:
Bug 3277255: [GRPC WLAN] digital_edge_source_raw parameter naming is inconsistent for SpecAn and WLAN for API "CfgDigitalEdgeTriggerRequest" in the proto file
Bug 3277313: [RFmx Instr] Grpc Server : Split APIs are missing
Bug 3277224: [WLAN] FetchReferenceDataConstellationTrace API not present in GRPC proto
Bug 3814050: Wrong gRPC implementation for RFmx APIs: VNA: CalkitManagerCalkitCalibrationElementSetPortConnectorsRequest and Pulse: FetchAcquiredAmplitudeTraceRequest
Why should this Pull Request be merged?
These changes bring the RFmxInstr, RFmxPulse, RFmxVNA, and RFmxWLAN generated gRPC metadata and code in line with the 26.5.0 RFmx APIs.
This fixes missing or incorrect gRPC API surfaces that would otherwise prevent users from calling the affected RFmxInstr Split APIs, WLAN reference constellation trace APIs, and the corrected RFmxVNA/RFmxPulse APIs through grpc-device.
The fixes also make the generated proto and service implementations consistent with the underlying driver API signatures and expected parameter names.
What testing has been done?
Manually inspected generated files.
Copied files from grpc-device-scrapigen/out/rfmxinstr/export/ to grpc-device/source/codegen/metadata/nirfmxinstr/ and built grpc-device successfully.
Manually inspected nirfmxinstr.proto file.
Copied files from grpc-device-scrapigen/out/rfmxpulse/export/ to grpc-device/source/codegen/metadata/nirfmxpulse/ and built grpc-device successfully.
Manually inspected nirfmxpulse.proto file.
Copied files from grpc-device-scrapigen/out/rfmxvna/export/ to grpc-device/source/codegen/metadata/nirfmxvna/ and built grpc-device successfully.
Manually inspected nirfmxvna.proto file.
Copied files from grpc-device-scrapigen/out/rfmxwlan/export/ to grpc-device/source/codegen/metadata/nirfmxwlan/ and built grpc-device successfully.
Manually inspected nirfmxwlan.proto file.