HLD updates for new Spright chat capabilities: welcome and disclaimer#2799
Merged
Conversation
jattasNI
changed the title
jattasNI
requested review from
atmgrifter00,
mollykreis and
rajsite
as code owners
hellovolcano
approved these changes
Jan 7, 2026
Contributor
Author
|
@mollykreis @rajsite heads up that I moved this out of draft and it's ready for your review. No intense time pressure, but I hope we'll have devs starting work on these components this month so I don't want to let it sit for too long. |
Member
|
FYI @jattasNI didn't get to it today and I'll be OOO rest of week, I don't expect to get to review till early next week |
mollykreis
reviewed
Jan 8, 2026
rajsite
reviewed
Jan 13, 2026
1 task
jattasNI
added a commit
that referenced
this pull request
Feb 2, 2026
# Pull Request ## 🤨 Rationale One of the tasks in #2610 is to create separate components for different message types instead of a single chat message with a `message-type` attribute. This would have some benefits: - certain APIs should only be available on certain message types (e.g. slots for `footer-actions` and `end` are only available on inbound messages) but are currently present on all - new message types will soon appear with more unique APIs and visual presentations. Candidates include welcome/login message (#2799), error message, tool progress message, context message. ## 👩💻 Implementation 1. Create new components `spright-chat-message-inbound`, `spright-chat-message-outbound`, `spright-chat-message-system` by copying existing message and removing code that was specific to other types. 2. Added framework wrappers 3. Marked existing `spright-chat-message` as deprecated. We can remove it once clients migrate to the new messages. 4. Updated docs and example apps to only refer to the new components 5. Updated HLD to reflect this plan ## 🧪 Testing 1. Duplicated unit tests from the original message type to the new ones. Some tests (e.g. Angular directive) could be removed because the message-type attribute no longer exists 2. Duplicated Chromatic tests for messages and for conversation message layout. Updated other conversation-specific tests to only refer to the new message components. 3. Visual inspection of storybook and example apps to ensure styling is correct ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
jattasNI
changed the title
OliverCosma
approved these changes
Feb 16, 2026
Contributor
Author
|
Bypassing @rajsite and @mollykreis for chat component HLD changes which you've already reviewed at a high level |
rajsite
reviewed
Feb 24, 2026
| - `title` - string attribute for the primary welcome message | ||
| - `subtitle` - string attribute for a secondary welcome message. Naming is aligned with `nimble-dialog` | ||
| - _Slots_ | ||
| - `brand-icon` slot can be used to customize the brand image. By default it will display a new icon `spright-icon-nigel-chat` which is a theme-aware custom icon (a custom element that derives from `IconSvg`) |
Member
There was a problem hiding this comment.
Alternate names:
start: aligned with pretty much everywhere else we place an iconbrand/brand-logo/logo: we aren't really treating the thing in there as an "icon" where we control the severity config and size it as--ni-nimble-icon-size(for those spots, like the mapping column, we take an attribute that is the tag-name of the icon so we can construct and manipulate programmatically). It's really just an image that we should style as::slotted(*){width:100%;height:100%}
aangerhofer
pushed a commit
that referenced
this pull request
May 27, 2026
…#2799) # Pull Request ## 🤨 Rationale We would like to unify as much of the chat implementation as practical across Angular and Blazor. These are two components that have Blazor implementations in an application codebase that we want in an Angular codebase too, so we want to introduce them to Spright: a welcome screen and a disclaimer at the bottom of the conversation. (Older Figma designs for illustration only) **Welcome** <img width="380" height="624" alt="chat-welcome-login" src="https://github.com/user-attachments/assets/c67b88eb-0afd-4996-85fa-5fa941758258" /> **Disclaimer** <img width="557" height="24" alt="chat-disclaimer" src="https://github.com/user-attachments/assets/2d44e960-4915-48a2-bdd4-eb418e57ea24" /> ## 👩💻 Implementation Update the chat component HLD with an implementation proposal for these components. ## 🧪 Testing N/A ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
We would like to unify as much of the chat implementation as practical across Angular and Blazor. These are two components that have Blazor implementations in an application codebase that we want in an Angular codebase too, so we want to introduce them to Spright: a welcome screen and a disclaimer at the bottom of the conversation.
(Older Figma designs for illustration only)
Welcome
Disclaimer
👩💻 Implementation
Update the chat component HLD with an implementation proposal for these components.
🧪 Testing
N/A
✅ Checklist