Skip to content

Add a section for a local workflow to CONTRIBUTING.md#19

Merged
jfriedri-ni merged 7 commits into
mainfrom
users/jfriedri/fix-typo
May 9, 2025
Merged

Add a section for a local workflow to CONTRIBUTING.md#19
jfriedri-ni merged 7 commits into
mainfrom
users/jfriedri/fix-typo

Conversation

@jfriedri-ni

@jfriedri-ni jfriedri-ni commented May 7, 2025

Copy link
Copy Markdown
Collaborator

What does this Pull Request accomplish?

  • Add a section describing a local workflow to CONTRIBUTING.md

Why should this Pull Request be merged?

It addresses a TODO comment in the file

What testing has been done?

  • Run analyzers and tests
  • Build docs

Signed-off-by: Joe Friedrichsen <joe.friedrichsen@emerson.com>
Signed-off-by: Joe Friedrichsen <joe.friedrichsen@emerson.com>
@jfriedri-ni jfriedri-ni added the documentation Improvements or additions to documentation label May 7, 2025
@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

Test Results

10 files  ±0  10 suites  ±0   8s ⏱️ +2s
 6 tests ±0   6 ✅ ±0  0 💤 ±0  0 ❌ ±0 
60 runs  ±0  60 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 80bc26f. ± Comparison against base commit e9622d7.

♻️ This comment has been updated with latest results.

@jfriedri-ni jfriedri-ni removed the request for review from mikeprosserni May 7, 2025 22:22
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread src/nipanel/_typing.py Outdated
@bkeryan

bkeryan commented May 8, 2025

Copy link
Copy Markdown
Collaborator

This also reminded me, we don't have Sphinx set up in this repo yet. I added it in #21

Comment thread CONTRIBUTING.md
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
Signed-off-by: Joe Friedrichsen <114173023+jfriedri-ni@users.noreply.github.com>
@jfriedri-ni jfriedri-ni merged commit 9502081 into main May 9, 2025
14 checks passed
@jfriedri-ni jfriedri-ni deleted the users/jfriedri/fix-typo branch May 9, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants