Skip to content

github: Specify required permissions for CI and PR workflows#29

Merged
bkeryan merged 1 commit into
mainfrom
users/bkeryan/fix-ci-permissions
May 20, 2025
Merged

github: Specify required permissions for CI and PR workflows#29
bkeryan merged 1 commit into
mainfrom
users/bkeryan/fix-ci-permissions

Conversation

@bkeryan

@bkeryan bkeryan commented May 19, 2025

Copy link
Copy Markdown
Collaborator

What does this Pull Request accomplish?

Make the CI and PR workflows work with Workflow permissions set to Read repository contents and packages permissions in the repo's GitHub Actions settings.

The https://github.com/EnricoMi/publish-unit-test-result-action action requires the ability to write to checks and PRs. Also, since this is a private repo, reading the repo contents is opt-in.

Why should this Pull Request be merged?

Principle of least privilege.

What testing has been done?

Tested with nitypes repo: ni/nitypes-python#53

I will not flip the switch in the settings until this is merged, to avoid disrupting other developers.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

10 files  ±0  10 suites  ±0   6s ⏱️ ±0s
 6 tests ±0   6 ✅ ±0  0 💤 ±0  0 ❌ ±0 
60 runs  ±0  60 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2d387d9. ± Comparison against base commit 8099e35.

@bkeryan bkeryan merged commit 5b1cef0 into main May 20, 2025
14 checks passed
@bkeryan bkeryan deleted the users/bkeryan/fix-ci-permissions branch May 20, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants