Skip to content

style: replace curly apostrophes with straight apostrophes - #1667

Merged
nicholas-fedor merged 1 commit into
mainfrom
style/replace-unicode-curly-apostrophes
May 23, 2026
Merged

style: replace curly apostrophes with straight apostrophes#1667
nicholas-fedor merged 1 commit into
mainfrom
style/replace-unicode-curly-apostrophes

Conversation

@nicholas-fedor

@nicholas-fedor nicholas-fedor commented May 23, 2026

Copy link
Copy Markdown
Owner

This PR standarizes the apostrophe character used throughout the codebase.

Change

  • Replace all instances of Unicode right single quotation mark (') with ASCII apostrophe (')

Summary by CodeRabbit

  • Style & Documentation
    • Updated documentation and comments throughout the codebase for consistency.

Review Change Stack

- Replace all instances of Unicode right single
  quotation mark (') with ASCII apostrophe (')
@nicholas-fedor
nicholas-fedor enabled auto-merge (squash) May 23, 2026 13:08
@coderabbitai

coderabbitai Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e75398ac-1b22-4803-b06f-f9d4960039c8

📥 Commits

Reviewing files that changed from the base of the PR and between 5095197 and e13438a.

📒 Files selected for processing (32)
  • build/mockery/mockery.yaml
  • cmd/notify-upgrade.go
  • cmd/root.go
  • internal/actions/doc.go
  • internal/actions/errors.go
  • internal/actions/mocks/progress.go
  • internal/actions/update.go
  • internal/flags/flags.go
  • internal/flags/flags_test.go
  • pkg/container/client.go
  • pkg/container/container.go
  • pkg/container/container_source.go
  • pkg/container/doc.go
  • pkg/container/errors.go
  • pkg/container/image.go
  • pkg/container/mocks/ApiServer.go
  • pkg/container/mocks/container_ref.go
  • pkg/lifecycle/lifecycle.go
  • pkg/notifications/email.go
  • pkg/notifications/gotify.go
  • pkg/notifications/msteams.go
  • pkg/notifications/shoutrrr.go
  • pkg/registry/auth/auth.go
  • pkg/registry/auth/auth_test.go
  • pkg/registry/manifest/manifest.go
  • pkg/registry/registry.go
  • pkg/registry/trust.go
  • pkg/session/container_status.go
  • pkg/session/progress.go
  • pkg/session/report.go
  • pkg/types/container.go
  • pkg/types/report.go

Walkthrough

This PR performs a comprehensive cleanup of apostrophe characters throughout the codebase, normalizing smart/curly apostrophes to straight ASCII characters in documentation comments, and extracts an error sentinel in manifest URL construction.

Changes

Apostrophe normalization and error handling refactor

Layer / File(s) Summary
Error sentinel extraction in manifest URL builder
pkg/registry/manifest/manifest.go
Introduces errFailedParseImageName as a package-level error variable and updates BuildManifestURL to wrap image name parse failures with this sentinel, moving the definition from inline to module scope.
Apostrophe character normalization across documentation
build/mockery/mockery.yaml, cmd/*, internal/actions/*, internal/flags/*, pkg/container/*, pkg/lifecycle/lifecycle.go, pkg/notifications/*, pkg/registry/*, pkg/session/*, pkg/types/*
Replaces smart/curly apostrophes with straight ASCII apostrophes in 34 files across package-level comments, function doc comments, inline documentation, error variable comments, and test comments without altering any code logic or exported signatures.

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: replacing curly apostrophes with straight apostrophes throughout the codebase.
Docstring Coverage ✅ Passed Docstring coverage is 95.83% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented May 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1667   +/-   ##
=======================================
  Coverage   75.01%   75.01%           
=======================================
  Files          58       58           
  Lines        9857     9857           
=======================================
  Hits         7394     7394           
  Misses       2203     2203           
  Partials      260      260           
Files with missing lines Coverage Δ
internal/actions/update.go 83.92% <ø> (ø)
internal/flags/flags.go 85.94% <ø> (ø)
pkg/container/client.go 63.55% <ø> (ø)
pkg/container/container.go 76.75% <ø> (ø)
pkg/container/container_source.go 95.23% <ø> (ø)
pkg/container/image.go 80.33% <ø> (ø)
pkg/lifecycle/lifecycle.go 100.00% <ø> (ø)
pkg/notifications/email.go 83.52% <ø> (ø)
pkg/notifications/gotify.go 70.96% <ø> (ø)
pkg/notifications/msteams.go 57.57% <ø> (ø)
... and 9 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nicholas-fedor
nicholas-fedor merged commit cb6ce73 into main May 23, 2026
18 of 20 checks passed
@nicholas-fedor
nicholas-fedor deleted the style/replace-unicode-curly-apostrophes branch May 23, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant