feat(spec): mandate local/CI toolchain parity in §10.5#35
Draft
niclaslindstedt wants to merge 1 commit intomainfrom
Draft
feat(spec): mandate local/CI toolchain parity in §10.5#35niclaslindstedt wants to merge 1 commit intomainfrom
niclaslindstedt wants to merge 1 commit intomainfrom
Conversation
Promotes the existing "Local/CI parity" recommendation in §10.3 to a full mandate (§10.5). Every language the CI workflow pins must have a matching root-level toolchain-pin file so `rustup` / `pyenv` / `nvm` / `asdf` auto-activate the same toolchain developers would otherwise have to install manually — closing the gap where `cargo clippy` passes locally with 1.85 but fails on CI with 1.88. Adds per-language examples (rust-toolchain.toml, .python-version, .nvmrc/.node-version, .go-version), ships the files as bootstrap templates, and wires a §10.5 check into `oss-spec validate`. The comparator tolerates harmless shapes (1.22 ≡ 1.22.0, local 3.12.4 matches CI 3.12) and requires byte-for-byte equality on non-numeric channels (nightly, lts/iron). Bumps OSS_SPEC.md to v2.1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust-toolchain.toml,.python-version,.nvmrc/.node-version,.go-version) and the tools that auto-activate each one (rustup, pyenv/uv/asdf, nvm/fnm/volta, goenv).templates/{rust,python,node,go}/so every generated repo is born compliant. Addsrust-toolchain.tomlto this repo to stay self-conformant.check_local_ci_parityintooss-spec validate(src/validate.rs). It reads CI workflows, detects language pins, and compares each against the matching root pin file. The comparator tolerates harmless shapes (1.22 ≡ 1.22.0, local3.12.4matches CI3.12) and requires byte-for-byte equality on non-numeric channels (nightly,lts/iron). Pure-docs /Genericrepos with no CI toolchain are a no-op.OSS_SPEC.md→ v2.1.0 (new mandate = minor) and the README badge to match. Updates §22 bootstrap checklist, theAGENTS.md/ template sync-points tables, and theverify-conformanceAI prompt so findings aren't duplicated.Test plan
cargo test— 64 validate tests, self-conformance, bootstrap smoke all green1.22.0 ≡ 1.22make lint(clippy -D warnings) — passesmake fmt-check— passesoss-spec validate --no-aion this repo reports clean; tamperingrust-toolchain.tomlto1.87.0surfaces the expected §10.5 violationbootstrap_smoke_teststill passes — generated Rust project ships the new pin file and is §10.5-conformant out of the boxhttps://claude.ai/code/session_01GiFmkySZGNYGTDWXnsb7w5