fix(mcp-panel): sanitize multiline text and make Keep & Close apply changes#14
Open
gpmarques wants to merge 1 commit intonicobailon:mainfrom
Open
fix(mcp-panel): sanitize multiline text and make Keep & Close apply changes#14gpmarques wants to merge 1 commit intonicobailon:mainfrom
gpmarques wants to merge 1 commit intonicobailon:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR applies a minimal, targeted fix to
mcp-panel.tsfor two UX/rendering issues in the/mcpTUI panel.Changes included
Sanitize display text
sanitizeDisplayText(...)to normalize external metadata used in rendering.Keep discard behavior
Enternow closes the panel and applies changes (done(buildResult())) instead of only leaving confirmation mode.Clarify button label
Protect row rendering from multiline content
row(...)to force one-line content before truncation, preventing box/layout corruption from multiline/control characters.Use sanitized values in server/tool rows
renderServerRow(...): sanitizeserver.nameandserver.importKind.renderToolRow(...): sanitizetool.nameandtool.description.Why
Two user-facing issues were reproducible in the current panel behavior:
Layout breaks with multiline tool descriptions
“Keep” in discard confirm is misleading