fix: support Codex MCP import from TOML config#31
Open
npo-mmenke wants to merge 1 commit intonicobailon:mainfrom
Open
fix: support Codex MCP import from TOML config#31npo-mmenke wants to merge 1 commit intonicobailon:mainfrom
npo-mmenke wants to merge 1 commit intonicobailon:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pi-mcp-adaptercurrently imports Codex MCP servers from~/.codex/config.jsonand expects them under
mcpServers.In current Codex installations, MCP servers are stored in
~/.codex/config.tomlunder[mcp_servers.<name>]instead.That means Pi's
imports: ["codex"]does not pick up MCP servers from amodern Codex setup, even though
codex mcp listshows them correctly.What this changes
~/.codex/config.tomlwhen importing Codex MCP configmcp_servers~/.codex/config.json/mcpServersfor backward compatibilityconfig.tomlexists but is invalidTests
Added coverage for:
Verification
npm test -- __tests__/config-imports.test.tsnpm test