feat: add seconds to the clock component in the dashboard - #8555
Open
samuelpert wants to merge 2 commits into
Open
feat: add seconds to the clock component in the dashboard#8555samuelpert wants to merge 2 commits into
samuelpert wants to merge 2 commits into
Conversation
Author
|
Hi @AndyLow91, this is my first contribution to this project. I've fixed #8048 by adding an opt-in SHOW_SECONDS browser setting that displays live seconds on the dashboard clock. This builds on the direction from a previous attempt (#8392) and addresses the review feedback that blocked it (lint error, test count, Azure appSettings wiring, trailing whitespace). Would appreciate a review when you have time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an opt-in
SHOW_SECONDSbrowser setting that displays live seconds on the dashboard clock, in both 12-hour and 24-hour time formats. When enabled, the clock format switches to include seconds (e.g.2:05:09 PM/14:05:09) and the clock refresh interval drops to 1 second so the seconds display stays live; when disabled (the default), behavior is unchanged. The setting is exposed via a checkbox in the browser Settings dialog, as an environment variable (SHOW_SECONDS), and as an Azure one-click deploy parameter.Why was this PR needed?
This closes #8048, a feature request for a seconds-capable dashboard clock. A previous attempt (#8392) implemented the same idea and was reviewed as directionally correct, but was blocked on four issues: a
no-redeclarelint error from redeclaringvar intervalin both branches ofupdateClock(), a settings test with a stale hard-coded env-var count, an Azure deploy parameter that was declared but never wired intositeConfig.appSettings, and trailing whitespace flagged bygit diff --check. This PR re-implements the feature from scratch following the same pattern as existing boolean browser settings (nightMode,editMode), which avoids all four issues by construction rather than patching them after the fact.What are the relevant issue numbers?
Closes #8048
Screenshots / Recordings (if applicable)
Does this PR meet the acceptance criteria?