Return an opaque error to the client instead of the error object - #8583
Open
NandhaKishorM wants to merge 1 commit into
Open
Return an opaque error to the client instead of the error object#8583NandhaKishorM wants to merge 1 commit into
NandhaKishorM wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Returns a fixed message instead of the raw
errorobject when a Loopnotification fails, and moves the existing log call above the response.
Why
res.send(error)serialises whatever the callback produced straight to thecaller. Depending on the failure that can include upstream APNs response
detail, file paths or configuration fragments. The
console.logimmediatelybelow already captures the full error server-side, so operators lose nothing by
keeping the client response opaque.
Maps to CWE-209.
Notes
One line changed plus the reordering. If you would rather return a structured
{ status, message }body to match other endpoints here, say so and I willamend.