Fix Glooko v3 request parameters - #60
Open
lukas-slansky wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents Glooko v2 synchronization parameters from being sent to v3 endpoints.
Fixes #59.
Problem
The Glooko
fetcher()currently applies the same query parameters to all GET requests:lastGuidlastUpdatedAtlimitThese parameters are used by the v2 synchronization endpoints, but Glooko v3 rejects them.
Affected endpoints include:
/api/v3/session/users/api/v3/graph/dataGlooko responds with:
Changes
fetcher()to receive explicit request parameters.Testing
Regression tests verify that:
lastGuid,lastUpdatedAt, andlimit/api/v3/session/usersdoes not receive them/api/v3/graph/datadoes not receive themThe full test suite passes.
The change was also tested against a real Glooko EU account using the current v3 graph fallback. The v2 CGM endpoint returned no readings, the v3 graph request completed successfully without HTTP 422, and the response produced 821 Nightscout CGM entries.