ci: bump actions to their Node 24 majors - #30
Merged
Conversation
Every action in this workflow targeted the Node 20 runtime, which GitHub has deprecated and is already force-running on Node 24. Move to the current majors so the behaviour is chosen rather than imposed: actions/checkout v4 -> v7 docker/login-action v3 -> v4 docker/metadata-action v5 -> v6 docker/build-push-action v5 -> v7 These majors are Node-24 runtime bumps; none of the removed inputs are used here. build-push-action v7 drops the deprecated DOCKER_BUILD_NO_SUMMARY and DOCKER_BUILD_EXPORT_RETENTION_DAYS envs plus legacy build-summary support, and metadata-action v6 changes no tag defaults, so the published tag set stays 0.4.0 + latest. Note the docker job only runs on release, so these four steps stay unverified until the next one. A failure there publishes nothing, since build-push-action pushes only after a successful build. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every action in
rust.ymltargeted the Node 20 runtime, which GitHub has deprecated. Both jobs in the 0.4.0 release run carried this annotation:They already execute on Node 24 — this makes that explicit rather than imposed, before the forced-runtime fallback goes away.
Changes
actions/checkoutdocker/login-actiondocker/metadata-actiondocker/build-push-actionI checked each crossed major's release notes rather than bumping blind. They are Node-24 runtime changes, and none of the removed surface is used here:
build-push-action@v7drops the deprecatedDOCKER_BUILD_NO_SUMMARY/DOCKER_BUILD_EXPORT_RETENTION_DAYSenvs and legacy build-summary support — not used.metadata-action@v6changes no tag defaults, so the published set stays0.4.0+latest.checkoutis used bare with nowith:block, so v4→v7 is inert for us.Verified all four target
node24by readingaction.ymlat each new tag.What this PR does and does not verify
The
buildjob exercisescheckout@v7directly, so that half is covered by CI here.The four docker-job steps stay unverified until the next release, since that job is gated on
github.event_name == 'release'— deliberately, per project preference for not building the image on PRs. The failure mode is safe:build-push-actionpushes only after a successful build, so a problem there fails the workflow without publishing anything.🤖 Generated with Claude Code