ci: hold rand at 0.8 until rsa 0.10 is stable - #46
Merged
Conversation
rand 0.9 moved to rand_core 0.9, but rsa 0.9 — still the latest stable release — takes its RNG as rand_core 0.6's `CryptoRngCore`. The two trait hierarchies are unrelated, so the throwaway RSA keypair minted for the cloudflare-authenticator tests cannot be generated from a newer rand without either an rsa release candidate or a hand-written adapter shim. Ignore major and minor rand bumps so the weekly run stops reopening a pull request that cannot compile, while still letting 0.8.x patches through. Both should be lifted together when rsa 0.10 ships stable.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to closing #43.
rand0.9 moved torand_core0.9, butrsa0.9 — still the latest stable release, with 0.10 at0.10.0-rc.18— takes its RNG asrand_core0.6'sCryptoRngCore. The two trait hierarchies are unrelated, so the throwaway RSA keypair thatcloudflare-authenticator's tests mint at run time cannot be generated from a newerrand:Without this entry the weekly run keeps reopening a pull request that cannot compile. Ignoring major and minor bumps still lets 0.8.x patches through, so a genuine fix in the 0.8 line would land normally.
randis a[dev-dependencies]entry, so this pins nothing in the released binary. Lift the ignore and bumprsaandrandtogether oncersa0.10 is stable.🤖 Generated with Claude Code