fix: eliminate per-request audience catalog copy (CWE-400) - #47
Merged
Conversation
…Set<String>> for improved performance
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Catalog.audsfromVec<String>toArc<HashSet<String>>— the catalog is built once at refresh time and shared across all concurrent requests via a cheap pointer cloneValidation::set_audiencefrom the per-request hot path — previously this deep-copied every audience string into a newHashSetbefore signature verification, allowing unauthenticated requests to drive allocation proportional to catalog sizejsonwebtoken::decode), audience membership checked after using a single O(1)HashSet::containslookup against the sharedArcvalidate_aud = falseonValidationto suppress jsonwebtoken v11's built-in audience check (which requires audiences to be pre-configured);required_spec_claimsstill enforces that theaudclaim is present in the tokenTest plan
cargo test --workspace— all 46 tests passcargo fmt --all --check— no formatting issuescargo clippy --workspace --all-targets -- -D warnings— no warnings🤖 Generated with Claude Code