feat: partial attribute completion#140
Draft
luckasRanarison wants to merge 3 commits intonikeee:masterfrom
Draft
feat: partial attribute completion#140luckasRanarison wants to merge 3 commits intonikeee:masterfrom
luckasRanarison wants to merge 3 commits intonikeee:masterfrom
Conversation
Owner
|
I added some CI and formatting checks to master and updated this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently attribute completion only works when being at the beginning of an attribute list or after a comma and need to be triggered manually after inserting
[or after,. Being able to autocomplete attribute when starting to type the attribute name itself would be really convinnient.For example, the following case doesn't get autocomplete:
This is an attempt to solve that problem but I'm stuck on the above case, the current node is
TextIdentifierand the previous node kind type isAttributeContainerbut this is also the case in the following situation (#17):So we don't have enough context... I'd be happy to hear your thoughts on this.