fixes # 25846; Uses decltype(auto) type when declaring temporal#25862
Draft
demotomohiro wants to merge 2 commits into
Draft
fixes # 25846; Uses decltype(auto) type when declaring temporal#25862demotomohiro wants to merge 2 commits into
decltype(auto) type when declaring temporal#25862demotomohiro wants to merge 2 commits into
Conversation
Contributor
Author
|
Need to fix #25870 to pass CI tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nim cpp generates C++ code like following from above Nim code:
But the type
T1isint, notint&so the value of local variablexwasn't changed.This PR changes type of temporal variables from
autotodecltype(auto)so that type of temporal variables become reference type when they are initialized with a function with reference return type.Following C++ shows how
autoanddecltype(auto)in variable declarations works differently:ref #25846