Added HtmlSpreadsheetParser using HtmlAgilityPack, all 109 tests pass.#93
Merged
Added HtmlSpreadsheetParser using HtmlAgilityPack, all 109 tests pass.#93
Conversation
Co-authored-by: tonyqus <tonyqus@users.noreply.github.com>
Member
|
/oc Create a new test file called TestHtmlSpreadsheetParser and move all new added unit test to this TestFixture |
Contributor
Author
|
Failed to create share (503): <title>Worker exceeded resource limits | opncd.ai | Cloudflare</title> <style>body{margin:0;padding:0}</style> <script> if (!navigator.cookieEnabled) { window.addEventListener('DOMContentLoaded', function () { var cookieEl = document.getElementById('cookie-alert'); cookieEl.style.display = 'block'; }) } </script>Error 1102 Ray ID: 9e50eced89b6b786 • 2026-03-31 17:03:06 UTCWorker exceeded resource limits |
Member
|
/oc Create a new test file called TestHtmlSpreadsheetParser and move all new added unit test to this TestFixture |
Co-authored-by: tonyqus <tonyqus@users.noreply.github.com>
Contributor
Author
|
Created |
Member
|
/oc fix 'TestHtmlSpreadsheetParser': member names cannot be the same as their enclosing type |
Co-authored-by: tonyqus <tonyqus@users.noreply.github.com>
Contributor
Author
|
Renamed the test method from |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


All 109 tests pass. Here's a summary of what was implemented:
Created
HtmlSpreadsheetParser.cs(ToxyFramework/Parsers/Spreadsheet/HtmlSpreadsheetParser.cs):ISpreadsheetParserinterfaceHtmlParseExceptionif the HTML has parse errors<table>element into a separateToxyTableinnerTextfor cell values (not HTML markup)idornameattributes, or defaults toTable_NUpdated
ParserFactory.cs:HtmlSpreadsheetParserfor.htmland.htmextensionsAdded test data (
Toxy.Test/testdata/Html/tables.html):Added tests (
TestToxySpreadsheet.cs):TestHtmlSpreadsheetParser- tests basic parsingTestHtmlSpreadsheetParserFirstTable- tests table structure and cell valuesTestHtmlSpreadsheetParserDirect- tests direct parser instantiationTestHtmlSpreadsheetParserNoTable- tests HTML with no tablesTestHtmlSpreadsheetParserInnerTextOnly- verifies innerText extraction (no HTML tags in values)Closes #92
opencode session | github run