chore: remove dead code (unused accessors, duplicate keychain fn, unused docs component) - #19
chore: remove dead code (unused accessors, duplicate keychain fn, unused docs component)#19nitin-1926 wants to merge 3 commits into
Conversation
HostInstalls has no callers anywhere; GlobalInstalls only its own test. CascadeInstalls already covers the global+host union that launch-time linking needs. Drop both methods and TestGlobalInstalls.
…MacKeychainOAuth The Default variant was byte-identical to DeleteMacKeychainOAuth in all three platform files (darwin, non-darwin stub, windows) — same service derivation, same per-account delete loop. Its single caller in set-default now calls DeleteMacKeychainOAuth directly; the survivor's doc comment absorbs the default-slot rationale.
Never imported anywhere in the docs site — only self-references.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0c99629 to
ad64b6f
Compare
1 participant
Removes verified-dead code surfaced by a repo-wide over-engineering audit. Pure deletions / dedup — no behavior change. All symbols grep-verified to have zero (or only self/test) callers across the module.
Changes
refactor(manifest)— dropManifest.HostInstalls()(zero callers) andManifest.GlobalInstalls()(only its own test).CascadeInstalls()already covers the global+host union used at launch-time linking. TestTestGlobalInstallsremoved with it.refactor(credentials)— foldDeleteMacKeychainOAuthDefaultintoDeleteMacKeychainOAuth. The two were byte-identical across all three platform files (darwin, non-darwin stub, windows). Its single caller (ccpm set-default→applyAPIKeyDefault) now calls the survivor directly; the default-slot rationale moves into the survivor's doc comment.chore(docs)— deleteCommandReferencecomponent; never imported anywhere in the docs site.Verification
go buildfor the affected packages passes on darwin/arm64, linux/amd64, windows/amd64 (the keychain change spans build-tagged files).go test ./internal/manifest/... ./internal/credentials/...green.Net: ~-90 lines, no dependency or API changes visible to users.
🤖 Generated with Claude Code