proton-pass-agent: adapt the services to match the documentation#9059
Open
delafthi wants to merge 1 commit intonix-community:masterfrom
Open
proton-pass-agent: adapt the services to match the documentation#9059delafthi wants to merge 1 commit intonix-community:masterfrom
delafthi wants to merge 1 commit intonix-community:masterfrom
Conversation
delafthi
force-pushed
the
delafthi/rpvyspksolkm
branch
2 times, most recently
from
beeb4e1 to
ed76bb0
Compare
See https://protonpass.github.io/pass-cli/commands/ssh-agent/#setting-ssh_auth_sock-automatically-on-login section 'Starting the daemon automatically on login'.
delafthi
force-pushed
the
delafthi/rpvyspksolkm
branch
from
ed76bb0 to
c6858bb
Compare
khaneliman
reviewed
Apr 13, 2026
| Crashed = true; | ||
| SuccessfulExit = false; | ||
| }; | ||
| ProcessType = "Background"; |
Collaborator
There was a problem hiding this comment.
Wouldn't it still be preferred to stay Background this will adjust how macOS handles the resources better as a background daemon.
Contributor
Author
There was a problem hiding this comment.
Initially, I thought that too, but as a background service, it often stopped running when I reopened the lid or after waking up from sleep/suspend. Declaring it as a normal service resolves these issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adapts the defined services (both systemd and launchd) to match the examples in the documentation. See https://protonpass.github.io/pass-cli/commands/ssh-agent/#setting-ssh_auth_sock-automatically-on-login section 'Starting the daemon automatically on login'.
Enhances service stability by reducing manual restarts, reducing operational disruption. Especially, on MacOS. I still face issues on Linux with the keyring, which usually involves a manual login and restarting the service after reboot.
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted nixf-diagnose --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.