Skip to content

Users mapping refactor - #3165

Draft
CorrenSoft wants to merge 2 commits into
nkdAgility:mainfrom
CorrenSoft:feat/corren/users-map
Draft

Users mapping refactor#3165
CorrenSoft wants to merge 2 commits into
nkdAgility:mainfrom
CorrenSoft:feat/corren/users-map

Conversation

@CorrenSoft

@CorrenSoft CorrenSoft commented Sep 8, 2026

Copy link
Copy Markdown

TLDR: Enhanced the TFS User Mapping Tool to support detailed identity mapping with complete source and target identity information, while maintaining backward compatibility with the existing simple dictionary format. Fixes #3164

As described in the associated issue, the user mapping implementation a documentation has become inconsistent over time, being the present PR a consolidation proposal, starting with the code.
The current changes are:

  • Adds a boolean property to TfsUserMappingToolOptions to control the format used in the Users' Map.
  • Updates the UserExportProcessor to use a List of IdentityMapData as output when the flag is active (right now, is exporting the whole identity class).
  • Updates the UserMappingTool to use the new format when flag is active, pre-validating that the input file is using the new format.
  • Adds a series of Unit Test covering several scenarios.

As mentioned before, changes are backward compatible, so any existing implementation should continue working as it is. The two working scenarios would be:

UseIdentityMapDataFormat = false (default)

{
    "source": "...",
    "target": "..."
}

UseIdentityMapDataFormat = true

[
  {
    "Source": {
      "DisplayName": "...",
      "AccountName": "..."
    },
    "Target": {
      "DisplayName": "...",
      "AccountName": "..."
    }
  }
]

Note

Pending to update documentation, which will happen if this proposal is accepted.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

CLAassistant commented Sep 8, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: User Mapping Documentation, Data Contracts and Implementation Appear to Use Different Formats

2 participants