Users mapping refactor - #3165
Draft
CorrenSoft wants to merge 2 commits into
Draft
Conversation
Added implementation of format auto-detection.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: Enhanced the TFS User Mapping Tool to support detailed identity mapping with complete source and target identity information, while maintaining backward compatibility with the existing simple dictionary format. Fixes #3164
As described in the associated issue, the user mapping implementation a documentation has become inconsistent over time, being the present PR a consolidation proposal, starting with the code.
The current changes are:
TfsUserMappingToolOptionsto control the format used in the Users' Map.As mentioned before, changes are backward compatible, so any existing implementation should continue working as it is. The two working scenarios would be:
UseIdentityMapDataFormat = false (default)
UseIdentityMapDataFormat = true
Note
Pending to update documentation, which will happen if this proposal is accepted.