Reject malformed honeypot timestamps - #62
Merged
Merged
Conversation
nickmoreton
marked this pull request as ready for review
July 15, 2026 21:29
nickmoreton
marked this pull request as draft
July 15, 2026 21:41
nickmoreton
marked this pull request as ready for review
July 16, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.worktrees/.Root cause
time_diff()converted the untrusted timestamp POST value directly withint(value). A present but empty or non-numeric field therefore raisedValueError(orTypeErrorfor non-string invalid inputs) rather than following the fail-closed behavior already used for missing honeypot fields.Impact
Malformed submissions are now silently ignored, continue to receive the normal thank-you response, and do not create a form submission. Valid timestamps, interval boundaries, settings, and template output are unchanged.
Closes #60.
Verification
uv run manage.py test tests.test_methods tests.test_form— 10 tests passedmake test— 17 tests passed; 100% package coveragemake lint— Ruff passedgit diff --check— passed