Mimeapp GUI plugin - #342
Conversation
|
Should solve: noctalia-dev/noctalia#1903 |
-tried to do grouping of basic types but doesn't work yet
|
that's so good, i got noctalia today and was just looking for something like that! how does one add this plugin? it doesn't show up in my available plugins list even though i already updated it |
|
Updated the gui on the Common page to allow easier change for some. Left the rest for more advance users. Added an IPC so users can create a .desktop if they don't want the icon on the bar. |
|
@ceviches when PR is accepted it will show up in the plugin list. If you want to use the plugin before you must download the folder and put it into your plugin folder which is: ~/.config/noctalia/plugins/ |
spiros132
left a comment
spiros132
left a comment
There was a problem hiding this comment.
Some general feedback, questions and comment I have about this PR :)
|
Thank you for the feedback, I am going away for a week or 2 and will look at your ideas when I get back. |
…lback literals - Added more i18n keys in en.json - Updated statusMessage and error handling to use i18n keys throughout - Removed duplicate toggle() IPC handler from Main.qml - Fixed a minor typo in README.md and updated IPC usage documentation
Automatic Code Quality ReviewFile: mimeapp-gui/BarWidget.qml
+ applyUiScale: falseFile: mimeapp-gui/Main.qmlFile: mimeapp-gui/Panel.qml |
spiros132
left a comment
spiros132
left a comment
There was a problem hiding this comment.
Some very minor things otherwise ready :)
Added logic to use capitalized group key as tab name if translation is missing Ensures user-friendly tab names even without i18n entry Uses string interpolation instead of concatenation
Automatic Code Quality ReviewFile: mimeapp-gui/BarWidget.qml
+ applyUiScale: falseFile: mimeapp-gui/Main.qmlFile: mimeapp-gui/Panel.qml |
…our changes. Lines starting
Automatic Code Quality ReviewFile: mimeapp-gui/BarWidget.qml
+ applyUiScale: falseFile: mimeapp-gui/Main.qmlFile: mimeapp-gui/Panel.qml |
|
Ignore the + applyUiScale: false bot review. This should be false for a barWidget. |
|
Can it be merge then. |
|
If you remove the official: false in the manifest, sure. |
|
Thanks |
4 participants
This plugin uses a Python script to scan .desktop files on your system, then lets you change which application is assigned to each MIME type by updating ~/.config/mimeapps.list.
I broke the mime types up into groups for each changing.