fix(screen-recorder): cap the resolution for h264 codec - #486
Merged
Conversation
Contributor
|
@Ly-sec - this PR modifies your plugin. Please review when you have a chance. |
Member
|
Hey @AlexNabokikh , could you please also bump the version in |
Contributor
Author
|
@Ly-sec sorry, I forgot about it. This is done. |
Member
That's all :) thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gpu-screen-recorderdoesn't allow resolution higher than 4096x4096 when using h264.So, if you try to start recording on the 5k screen (5120x2880) the plugin will fail with an error:
This small change caps the resolution to 4096x4096 when using h264.