refactor(taskbar): refactor taskbar layout with flex and button - #3377
Conversation
|
Hey @enklht I just tested your PR and it seems like there are some miscalculations uappening. It seems like the badges can get clipped, there were a few reasons why we had this random math in place, mostly to keep the badges properly positioned :). |
|
Thanks @Ly-sec for checking! I've converted this to a draft PR. |
fa054e7 to
5b17186
Compare
|
Hi @Ly-sec, I adjusted the padding dimension so badges wont get clipped. |
|
Hey @enklht sorry for the late response, I was quite busy :). Would you mind resolving the conflicts? Afterwards I'll gladly merge it. |
…rner of the center to avoid overlap
5b17186 to
2c14992
Compare
|
Thanks @Ly-sec for the review! |
|
Thank you very much, I'll merge it :). |
Summary
This PR rewrites taskbar implementation to use
ui::flex,ui::buttonto reduce manually computed positionings.Motivation
The manual layout math made it hard to reason about the placement.
I believe making proper use of flex layout makes the codebase more maintainable, verifiable.
Type of Change
Related Issue
none
Testing
Testing was primarily on a horizontal bar, with additional validation on a vertical bar.
Manual Coverage
Screenshots / Videos
screenshots on horizontal bars:
without workspace grouping:

without workspace labels:

workspace labels at corners:

workspace labels at center:

workspace labels inside the pill:

Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes